persistent-postgresql: Newtype conversions in PersistDbSpecific#160
Merged
snoyberg merged 1 commit intoyesodweb:masterfrom Sep 20, 2013
Merged
persistent-postgresql: Newtype conversions in PersistDbSpecific#160snoyberg merged 1 commit intoyesodweb:masterfrom
snoyberg merged 1 commit intoyesodweb:masterfrom
Conversation
…rk around postgresql-simple type checking for conversions of internal postgres types
Contributor
Author
|
The PersistFieldSql instance should be otherwise persistent keeps doing a migration. |
Member
|
that looks great! I will let @snoyberg merge this. The name of Unknown should be changed to something slightly more specific if it would ever get exported. |
Contributor
Author
|
Awesome! I think this will break the existing Geo example by the way, it shouldn't need to manually escape the bytestring anymore. |
snoyberg
added a commit
that referenced
this pull request
Sep 20, 2013
persistent-postgresql: Newtype conversions in PersistDbSpecific
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #153, this adds a newtype around
PersistDbSpecificconversions that doesn't do validation. This way native postgresql types that persistent doesn't handle by default can be converted to ByteString.Example for UUID: