Treat unknown extension types as PersistDbSpecific values#385
Treat unknown extension types as PersistDbSpecific values#385snoyberg merged 2 commits intoyesodweb:masterfrom
Conversation
|
@meteficha Since (I believe) you wrote this code originally, do you have any thoughts on this change? |
|
IIUC, this pull request is reverting most of e0413f5, which will bring us to the state we were at afea41e. I've never used this stuff, but it seems @albertov knows what he's doing since he's the author of both commits above :). I just don't understand why we should keep things like |
|
@meteficha, Indeed, we're almost going back full circle :) I guess my rationale for e0413f5 was to be more explicit but now that I need access to more types I think it's better to map to a Regarding the the redundancy in |
Treat unknown extension types as PersistDbSpecific values
|
Merged, thanks! |
3 participants
I'm in the process of implementing a library to create PostgreSQL full text search queries using Esqueleto (https://github.com/albertov/esqueleto-textsearch) and I need to create
PersistFieldinstance for postgres'tsvector,regconfigandtsquerytypes. I was tempted to add another set of converters for these types inbuiltInExtensionGettersbut since it's not the first time I've done this (see #313) I think a more future-proof solution would be to treat all unknown oids asPersistDbSpecificvalues and let thePersistFieldinstances parse them as they see fit.