More BackendCompatible generalizations by parsonsmatt · Pull Request #723 · yesodweb/persistent

parsonsmatt · 2017-10-24T17:47:34Z

This PR includes some additional generalizations. Unfortunately, my work project does not use the SqlReadT or SqlWriteT features, and it was only when the code was tested on those did the issues with Esqueleto come up.

This PR generalizes SqlReadT so that Esqueleto can be updated in a way that doesn't cause any breaking changes.

If any folks are using SqlReadT, I'd appreciate testing this PR/commit out with this Esqueleto PR to verify that it doesn't break any corner cases I've missed 😄

parsonsmatt · 2017-10-24T17:50:19Z

persistent/Database/Persist/Sql/Raw.hs


 -- | Execute a raw SQL statement
-rawExecute :: MonadIO m
+rawExecute :: (MonadIO m, BackendCompatible SqlBackend backend)


These functions needed to be generalized to satisfy Esqueleto.

parsonsmatt · 2017-10-24T17:50:46Z

persistent/Database/Persist/Sql/Migration.hs

 import Database.Persist.Sql.Types
 import Database.Persist.Sql.Raw
 import Database.Persist.Types
+import Database.Persist.Sql.Orphan.PersistStore()


This import is necessary for the BackendCompatible SqlBackend SqlBackend instance.

dariooddenino · 2017-10-25T10:54:17Z

Compilation of persistent-mysql-2.6.2 fails with this branch. persistent-mysql-2.6.1 works fine.

Progress: 2/3
--  While building package persistent-mysql-2.6.2 using:
      /home/dario/.stack/setup-exe-cache/x86_64-linux-nopie/Cabal-simple_mPHDZzAJ_1.24.2.0_ghc-8.0.2 --builddir=.stack-work/dist/x86_64-linux-nopie/Cabal-1.24.2.0 build --ghc-options " -ddump-hi -ddump-to-file"
    Process exited with code: ExitFailure 1
    Logs have been written to: /home/dario/dev/blue-moon/.stack-work/logs/persistent-mysql-2.6.2.log

    Configuring persistent-mysql-2.6.2...
    Building persistent-mysql-2.6.2...
    Preprocessing library persistent-mysql-2.6.2...
    [1 of 1] Compiling Database.Persist.MySQL ( Database/Persist/MySQL.hs, .stack-work/dist/x86_64-linux-nopie/Cabal-1.24.2.0/build/Database/Persist/MySQL.o )
    
    /tmp/stack4584/persistent-mysql-2.6.2/Database/Persist/MySQL.hs:1188:17: error:
        • Could not deduce (BackendCompatible r0 backend)
            arising from a use of ‘projectBackend’
          from the context: (backend ~ PersistEntityBackend record,
                             BackendCompatible SqlBackend backend,
                             PersistEntity record,
                             MonadIO m)
            bound by the type signature for:
                       insertManyOnDuplicateKeyUpdate :: (backend
                                                          ~
                                                          PersistEntityBackend record,
                                                          BackendCompatible SqlBackend backend,
                                                          PersistEntity record, MonadIO m) =>
                                                         [record]
                                                         -> [SomeField record]
                                                         -> [Update record]
                                                         -> ReaderT backend m ()
            at Database/Persist/MySQL.hs:(1175,1)-(1185,27)
          The type variable ‘r0’ is ambiguous
          Relevant bindings include
            insertManyOnDuplicateKeyUpdate :: [record]
                                              -> [SomeField record]
                                              -> [Update record]
                                              -> ReaderT backend m ()
              (bound at Database/Persist/MySQL.hs:1186:1)
          These potential instances exist:
            instance BackendCompatible SqlBackend SqlBackend
              -- Defined in ‘persistent-2.7.1:Database.Persist.Sql.Orphan.PersistStore’
            instance BackendCompatible SqlBackend SqlReadBackend
              -- Defined in ‘persistent-2.7.1:Database.Persist.Sql.Orphan.PersistStore’
            instance BackendCompatible SqlBackend SqlWriteBackend
              -- Defined in ‘persistent-2.7.1:Database.Persist.Sql.Orphan.PersistStore’
        • In the first argument of ‘withReaderT’, namely ‘projectBackend’
          In the first argument of ‘(.)’, namely ‘withReaderT projectBackend’
          In the expression: withReaderT projectBackend . uncurry rawExecute
    
    /tmp/stack4584/persistent-mysql-2.6.2/Database/Persist/MySQL.hs:1189:15: error:
        • Could not deduce (BackendCompatible SqlBackend r0)
            arising from a use of ‘rawExecute’
          from the context: (backend ~ PersistEntityBackend record,
                             BackendCompatible SqlBackend backend,
                             PersistEntity record,
                             MonadIO m)
            bound by the type signature for:
                       insertManyOnDuplicateKeyUpdate :: (backend
                                                          ~
                                                          PersistEntityBackend record,
                                                          BackendCompatible SqlBackend backend,
                                                          PersistEntity record, MonadIO m) =>
                                                         [record]
                                                         -> [SomeField record]
                                                         -> [Update record]
                                                         -> ReaderT backend m ()
            at Database/Persist/MySQL.hs:(1175,1)-(1185,27)
          The type variable ‘r0’ is ambiguous
          These potential instances exist:
            instance BackendCompatible SqlBackend SqlBackend
              -- Defined in ‘persistent-2.7.1:Database.Persist.Sql.Orphan.PersistStore’
            instance BackendCompatible SqlBackend SqlReadBackend
              -- Defined in ‘persistent-2.7.1:Database.Persist.Sql.Orphan.PersistStore’
            instance BackendCompatible SqlBackend SqlWriteBackend
              -- Defined in ‘persistent-2.7.1:Database.Persist.Sql.Orphan.PersistStore’
        • In the first argument of ‘uncurry’, namely ‘rawExecute’
          In the second argument of ‘(.)’, namely ‘uncurry rawExecute’
          In the expression: withReaderT projectBackend . uncurry rawExecute

parsonsmatt · 2017-11-03T01:36:30Z

Good catch @dariooddenino The generalizations I'm making here make the preemptive persistent-mysql generalizations unnecessary :)

paul-rouse · 2017-11-03T08:53:16Z

@parsonsmatt This is looking good! Could you please rebase to the latest master, and make the changelog message describe the whole PR (include a link to the PR too) instead of saying it fixes a compilation error (which was just an intermediate step!)? Then, assuming travis is still OK, I can merge it.

parsonsmatt · 2017-11-03T23:31:17Z

Weird spurious build failure: https://travis-ci.org/yesodweb/persistent/jobs/296983378 Tests passed and all :\

paul-rouse · 2017-11-04T09:40:06Z

Looked like a last-minute glitch. I restarted that test and it is fine now.

Thanks for all of this - I'll go ahead and merge it.

This reverts commit 7c00533.

Revert "More BackendCompatible generalizations (#723)"

This reverts commit 8617b7b.

parsonsmatt commented Oct 24, 2017

View reviewed changes

parsonsmatt mentioned this pull request Oct 24, 2017

Add a class for backend compatibility bitemyapp/esqueleto#53

Merged

parsonsmatt added 4 commits November 3, 2017 15:08

generalize SqlReadT

41db41f

more generalization

c2f284a

fix mysql

f25a638

update changelogs, warning

f7afdea

parsonsmatt force-pushed the matt/generalize-sqlreadt branch from 150c89b to f7afdea Compare November 3, 2017 21:18

Add ChangeLog link

f7a472b

paul-rouse approved these changes Nov 4, 2017

View reviewed changes

paul-rouse merged commit 7c00533 into yesodweb:master Nov 4, 2017

paul-rouse mentioned this pull request Nov 25, 2017

Thoughts on releases, please #740

Closed

This was referenced Dec 16, 2017

Add Generic instance and remove constraint on Entity #734

Merged

Re-release Persistent 2.7.2 as 2.8 #758

Closed

MaxGabriel added a commit that referenced this pull request Dec 17, 2017

Revert "More BackendCompatible generalizations (#723)"

7a5ea33

This reverts commit 7c00533.

MaxGabriel added a commit that referenced this pull request Dec 17, 2017

Revert "More BackendCompatible generalizations (#723)"

8617b7b

This reverts commit 7c00533.

MaxGabriel added a commit that referenced this pull request Dec 19, 2017

Merge pull request #759 from yesodweb/revert723

fb1a134

Revert "More BackendCompatible generalizations (#723)"

snoyberg added a commit that referenced this pull request Jan 16, 2018

Revert "Revert "More BackendCompatible generalizations (#723)""

4d0a6f3

This reverts commit 8617b7b.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More BackendCompatible generalizations#723

More BackendCompatible generalizations#723
paul-rouse merged 5 commits intoyesodweb:masterfrom
parsonsmatt:matt/generalize-sqlreadt

parsonsmatt commented Oct 24, 2017

Uh oh!

parsonsmatt Oct 24, 2017

Uh oh!

parsonsmatt Oct 24, 2017

Uh oh!

dariooddenino commented Oct 25, 2017

Uh oh!

parsonsmatt commented Nov 3, 2017

Uh oh!

paul-rouse commented Nov 3, 2017

Uh oh!

parsonsmatt commented Nov 3, 2017

Uh oh!

paul-rouse commented Nov 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

parsonsmatt commented Oct 24, 2017

Uh oh!

parsonsmatt Oct 24, 2017

Choose a reason for hiding this comment

Uh oh!

parsonsmatt Oct 24, 2017

Choose a reason for hiding this comment

Uh oh!

dariooddenino commented Oct 25, 2017

Uh oh!

parsonsmatt commented Nov 3, 2017

Uh oh!

paul-rouse commented Nov 3, 2017

Uh oh!

parsonsmatt commented Nov 3, 2017

Uh oh!

paul-rouse commented Nov 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants