pass Connection into step, so it can be provided to sqlError#730
Closed
dlthomas-leapyear wants to merge 1 commit intomasterfrom
unknown repository
Closed
pass Connection into step, so it can be provided to sqlError#730dlthomas-leapyear wants to merge 1 commit intomasterfrom unknown repository
dlthomas-leapyear wants to merge 1 commit intomasterfrom
unknown repository
Conversation
This gives us a more informative error message than "SQLite3 returned ErrorError while attempting to perform step.", which isn't a very good starting point for debugging.
Contributor
|
This looks fine. Could you please add a minor version bump and a changelog entry, please? |
Member
|
@dlthomas-leapyear Just checking back in if you're able to bump the version number in the cabal file and the changelog, otherwise I was going to take this over. Thanks for your fix! |
Member
|
I ended up handling the changelog/cabal bump in #743. Thanks @dlthomas-leapyear! |
Contributor
Author
|
@MaxGabriel Thanks for getting this! I've been away from the computer for a bit, with the holiday. |
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives us a more informative error message than "SQLite3 returned
ErrorError while attempting to perform step.", which isn't a very good
starting point for debugging.
I don't know whether there was a good reason it wasn't done this way originally - I dug a bit (across a few repositories) but wasn't able to find where that code originated.