More verbose error messages when failing to parse database results in…#741
Merged
MaxGabriel merged 4 commits intomasterfrom Jan 17, 2018
Merged
More verbose error messages when failing to parse database results in…#741MaxGabriel merged 4 commits intomasterfrom
MaxGabriel merged 4 commits intomasterfrom
Conversation
gregwebs
approved these changes
Dec 4, 2017
Member
gregwebs
left a comment
There was a problem hiding this comment.
awesome, looks like just a doc conflict with master now.
…to Persistent records
(Avoids GHC version monoid import issues)
…Encoding.Error This was necessary because of the following situation: 1. I wanted to use Data.Text.replace inside the instance for Natural, which is in an ifdef for GHC 7.8 2. I couldn't do T.replace, because two modules aliased as T exported a replace 3. I couldn't import replace directly from Data.Text without getting unused function errors on old GHCs, because the function was ifdefed out Since it probably should be done anyway, I disambiguated the module imports as T, TE, and TERR, allowing me to use T.replace
b2487b2 to
36dffb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…to Persistent records
Closes #689
Previous error message, as reported in #689:
New error message:
This is maybe a little bit more verbose than ideal, imo, but I lean towards a verbose error message because you should only see this error message if your PersistField instances are incorrect, or your database schema doesn't match your persist model definitions (afaik). It's also kind of hard to make a clean error message because the error is constructed from several different locations in the code.
Specific improvements:
field foo: int Expected Integer, received: PersistText "foo", it's totally unclear whatintis, and calling itintdoesn't suggest that it's a Haskell type (vs Int).getit's hard to realize that function is the root of the problem.Behavior change: A handful of the PersistField parsing functions called
errorinstead of returningLeft Text. I think since the vast majority returnedLeftthat it's fine to change this. I also can't imagine anyone is relying on the error vs left distinction, especially because higher level functions likegetjust callerrorthemselves on aLeft.