Addition of the "question mark" operators to persistent-postgresql#863
Closed
Vlix wants to merge 26 commits intoyesodweb:masterfrom
Vlix:master
Closed
Addition of the "question mark" operators to persistent-postgresql#863Vlix wants to merge 26 commits intoyesodweb:masterfrom Vlix:master
Vlix wants to merge 26 commits intoyesodweb:masterfrom
Vlix:master
Conversation
… and new Filter operators (@>.) and (<@.)
* Upgraded the randomValues function in DataTestTypes.hs to actually have random values everytime * small OCD
…work because of it
Contributor
Author
|
Ok, so nothing seems to make the CI happy. If there is, do tell me, because this seems rather limiting. |
Collaborator
|
@Vlix I'm currently updating CI to include newer versions of LTS. I believe that it was just overlooked in the past. I'm going to cancel your current CI build to let the new CI finish faster. If you'd like to merge those changes in when they're done, that'd be great 😄 |
Contributor
Author
|
I noticed I did everything on the master branch. Closing this PR and making a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
postgresql-simple-0.6.1, question marks can now be escaped in the SQL query (by doubling them), so nowpersistentcan also use them.Had to add a few new data constructors to have the resulting query be correct, and am looking into a way to make the other JSON operators work in
persistentqueries, but those will take some more thinking/experimenting time.This does mean the
postgresql-simpleversion's lower bound is upped to 0.6.1, so I've increased thepersistent-postgresqlversion to2.10.0Oh, and I also upped the stackage LTS to 13.13, I figured it wouldn't hurt. If I'm wrong, either the CI will break or I hope someone will inform me.