Merged
Conversation
… and new Filter operators (@>.) and (<@.)
* Upgraded the randomValues function in DataTestTypes.hs to actually have random values everytime * small OCD
…work because of it
Vlix
reviewed
Apr 15, 2019
Contributor
Vlix
left a comment
Vlix
left a comment
There was a problem hiding this comment.
Found two things. Trivial though.
Anything I still need to look at? Didn't have any time today, but could work on it tomorrow, I think.
| -- Returns also the identifiers. | ||
| selectSourceRes | ||
| :: (PersistRecordBackend record backend, MonadIO m1, MonadIO m2) | ||
| :: (PersistEntity record, PersistRecordBackend record backend, MonadIO m1, MonadIO m2) |
Contributor
There was a problem hiding this comment.
Isn't this redundant? PersistRecordBackend record backend is a synonym for PersistEntity Record and something else iirc
|
|
||
| -- | Get just the first record for the criterion. | ||
| selectFirst :: (MonadIO m, PersistRecordBackend record backend) | ||
| selectFirst :: (MonadIO m, PersistEntity record, PersistRecordBackend record backend) |
Collaborator
Author
There was a problem hiding this comment.
Good catch! I've pruned those constraints.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A continuation of #886