Fix Unique Constraints in SQlite#922
Merged
parsonsmatt merged 1 commit intoyesodweb:matt/sqlite-unique-constraintsfrom Jul 17, 2019
Merged
Fix Unique Constraints in SQlite#922parsonsmatt merged 1 commit intoyesodweb:matt/sqlite-unique-constraintsfrom
parsonsmatt merged 1 commit intoyesodweb:matt/sqlite-unique-constraintsfrom
Conversation
Collaborator
|
Can you force-push an empty commit to get the CI to build? |
Collaborator
|
I'm going to merge as-is into a new branch, which should trigger CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQlite seems to ignore Unique Keys when there is a Primary Key.
This
translates into
CREATE TABLE "person"("name" VARCHAR NOT NULL,"creditcard" INTEGER NOT NULL, PRIMARY KEY ("name"))while after the fix
CREATE TABLE "person"("name" VARCHAR NOT NULL,"creditcard" INTEGER NOT NULL, PRIMARY KEY ("name"),CONSTRAINT "unique_a" UNIQUE ("creditcard"))Before submitting your PR, check that you've:
@sincedeclarations to the HaddockAfter submitting your PR: