Replace liftPersist, fixes #933#934
Merged
parsonsmatt merged 1 commit intoyesodweb:masterfrom Jul 24, 2019
Merged
Conversation
Collaborator
|
Ok, just getting back to a computer now - this should be good to release a 2.10.4 that is fixed up? |
Contributor
Author
|
Yeah, I haven't exhaustively tested them all, but everything I use works and given the simplicity of what broke and how this fixes it, it seems unlikely that there's any reason they wouldn't all work fine. I'm working on ripping the "BaseBackend backed ~ backend" stuff out of the tests so they can be more easily applied to derived backends (and so I can rerun the tests with this backend), but it's a substantial amount of work and it's a bit low priority, so it might be awhile until I wrap it up. |
Collaborator
|
Uploaded as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the broken instances in 2.10.2 and 2.10.3, but we should probably add tests to avoid this happening again.