Skip to content

WIP: Got rid of silently#965

Closed
NorfairKing wants to merge 1 commit intoyesodweb:masterfrom
NorfairKing:remove-silently
Closed

WIP: Got rid of silently#965
NorfairKing wants to merge 1 commit intoyesodweb:masterfrom
NorfairKing:remove-silently

Conversation

@NorfairKing
Copy link
Contributor

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@parsonsmatt
Copy link
Collaborator

Thanks for the PR! This implementation was a breaking change to behavior, and would have required a major bump. The PR in #971 added Quiet variants and documented the thread-unsafety of this function, and will be released soon in 2.10.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants