Merged
Conversation
parsonsmatt
commented
Oct 25, 2019
| toEntityName = U.fromString . unpack . unDBName . entityDB | ||
|
|
||
| mkEntity :: (Monad m, PersistEntity val) => Key val -> [(B.ByteString, B.ByteString)] -> m (Entity val) | ||
| mkEntity :: (MonadFail m, PersistEntity val) => Key val -> [(B.ByteString, B.ByteString)] -> m (Entity val) |
Collaborator
Author
There was a problem hiding this comment.
technically a breaking change, but it's an .Internal module, so yolo
| @@ -1,5 +1,5 @@ | |||
| name: persistent-redis | |||
| version: 2.5.2.2 | |||
| version: 2.5.2.3 | |||
Collaborator
Author
There was a problem hiding this comment.
should possibly be a major bump, but only type-changing thing is in the internal module
parsonsmatt
commented
Oct 28, 2019
| it "issue #527" $ asIO $ runSqliteInfo (mkSqliteConnectionInfo ":memory:") $ do | ||
| runMigration migrateAll | ||
| insertMany_ $ replicate 1000 (Test $ read "2014-11-30 05:15:25.123") | ||
| insertMany_ $ replicate 1000 (Test $ read "2014-11-30 05:15:25.123Z") |
Collaborator
Author
There was a problem hiding this comment.
I guess the Read instance for UTCTime changed :|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the HaddockAfter submitting your PR:
Well,
persistent-mongoDB'smongoDBdependency is causing issues, so we're not building it - otherwise it'd fail the whole build.