Update SQLite amalgamation to 3.30.1#991
Merged
parsonsmatt merged 3 commits intoyesodweb:masterfrom Jan 28, 2020
Merged
Conversation
Contributor
Author
|
The version bump/changelog assume #983 gets merged first, I can rebase/fix any merge conflicts when that happens. |
5 tasks
parsonsmatt
approved these changes
Dec 28, 2019
Collaborator
parsonsmatt
left a comment
parsonsmatt
left a comment
There was a problem hiding this comment.
LGTM but I'm not really in a position to say how safe this is as a minor version. It's a minor version bump of a dependency so it should be fine as a minor version bump.
Contributor
Author
|
As far as I can tell from the SQLite release notes there shouldn't be any regressions/backwards incompatibilities between this and the current version. But I can change it to a major bump to be on the safe side. |
Collaborator
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the upgrade is backwards compatible I guess this should just be a minor bump?
Before submitting your PR, check that you've:
After submitting your PR: