Merged
Conversation
on 32 bits systems, it needs more testing though
(maybe issues could still exists in summary print)
ghost
assigned
zakird
pushed a commit
that referenced
this pull request
Feb 14, 2024
* fist pass at a debian workflow * Refactored debian workflow into a common bsd/linux yml. Edited Dockerfile * attempt #2 * attempt #3 * attempt #4 * attempt #5 * attempt #6 * attempt #7 * attempt #8 * attempt #9 * attempt #10, at least we're getting into the debian dockerfile * Looks like its working, causing a compile error in get_gateway_linux to see if check fails * Confirmed, debian workflow is working! * Removed debugging ls in .yml * testing arch build * Added fedora test * testing Gentoo test * phillip/773: refactored all the github compile actions to be in a single .yml file * phillip/773: added arch and gentoo Install instructions * phillip/773: removed extra space in arch.Dockerfile * phillip/773: apparently the free-bsd vm is picky about having the run being on the same line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you're interested, I wrote a quick and dirty workaround to let ZMap compile and work on 32 bit systems,
AFAIK, possible issues should be introduced only on the summary print (ignoring the couple of bytes of memory now
overallocated on 64bits).
Please ignore first commit, it was just an attempt to get ZMap to compile (and I had not realized yet the point of the lsh to generate the whole 2^32 IPv4 number).
Just noted I put "long long" and "unsigned long long" in different functions, but, for the purpose, they're pretty interchangeable.
Kudos for the very good work.