Skip to content

Bugfix: Passing no port to ICMP module (or any module without a port requirement) causes segfault#731

Merged
dadrian merged 1 commit intomainfrom
no-port-bugfix
Sep 26, 2023
Merged

Bugfix: Passing no port to ICMP module (or any module without a port requirement) causes segfault#731
dadrian merged 1 commit intomainfrom
no-port-bugfix

Conversation

@zakird
Copy link
Member

@zakird zakird commented Sep 25, 2023

Fixes #730

@zakird zakird requested a review from dadrian September 25, 2023 16:05
Copy link
Member

@dadrian dadrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we free the memory?

Nah.

@dadrian dadrian merged commit 146ded1 into main Sep 26, 2023
@dadrian dadrian deleted the no-port-bugfix branch September 26, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segementation fault when no target ports are provided (e.g. ICMP)

2 participants