phillip/fix-bug-cmake-lists: fixed hard-coded path#742
Merged
Conversation
zakird
approved these changes
Nov 17, 2023
Member
|
Fixes #735 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
CONFIG_DESTINATIONvariable instead of a hard-coded value (/etc/zmap) for the install path for the config filesTesting
Per
INSTALL.md, I rancmake -DRESPECT_INSTALL_PREFIX_CONFIG=ON .; make -j4; make installThis was output for
make install. You can see the*.conffiles were installed not at the usual/etc/zmapbut at/usr/local/etc/zmap/, showing the config install prefix was respected.