Set default senders as min(4, number of cores on host)#752
Merged
phillip-stephens merged 6 commits intomainfrom Dec 11, 2023
Merged
Set default senders as min(4, number of cores on host)#752phillip-stephens merged 6 commits intomainfrom
phillip-stephens merged 6 commits intomainfrom
Conversation
Member
|
Sorry, I was totally backwards in that last comment (deleted). Should have coffee before looking at it. That said, I think we might want to default to one less than the number of cores so that there is one core available for the receiver thread. |
zakird
approved these changes
Dec 9, 2023
Member
|
@phillip-stephens I have pushed slightly updated logic. Can you take a quick look, and if it looks good to you too, we can merge? |
Contributor
Author
|
@zakird LGTM, thanks! Merging now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should give us a more sane default, especially on hosts with less cores.
--helpTesting
Ran on Mac, compiles and runs correctly
To test if it picks up cores correctly, ran on a Ubuntu VM with 2 cores, it detected this correctly.