Align --retries default with --help and manual pages#755
Merged
Conversation
…s = 10, per --help text
…e consistent with other naming
…correcting naming mistake
zakird
approved these changes
Dec 14, 2023
Member
|
These should obviously match. I wonder though whether we want to change the default behavior, or if we want to have the help text match the behavior. |
Contributor
Author
|
Yeah, I thought about that. Figured I'd issue the PR and we can discuss here. My impression is that packets failing to send would be a relatively rare event and making the default If you don't have any objections, I can modify the PR to do this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--helptext and true default for--retries.