Add option to change "recursion desired" bit in DNS probe module#764
Merged
phillip-stephens merged 6 commits intozmap:mainfrom Jan 26, 2024
Merged
Add option to change "recursion desired" bit in DNS probe module#764phillip-stephens merged 6 commits intozmap:mainfrom
phillip-stephens merged 6 commits intozmap:mainfrom
Conversation
Member
|
Thanks for putting this together. In terms of help text, it would be best to update the blurb in the probe module registration, which is where we store documentation specific to a given probe module. This blurb: |
Member
|
@phillip-stephens This looks good to me overall. Once we have documentation included in the PR, can you get merged? |
Contributor
Author
|
I have updated the documentation and marked the PR as ready to review. Please let me know of there is anything I can do to improve the proposed code changes. Thank you for your time! |
9 tasks
phillip-stephens
previously approved these changes
Jan 26, 2024
Contributor
phillip-stephens
left a comment
phillip-stephens
left a comment
There was a problem hiding this comment.
LGTM, thanks @gutjuri !!!
phillip-stephens
dismissed
their stale review
Didn't notice the 0xFF bit, have 1 question about it before we merge.
phillip-stephens
approved these changes
Jan 26, 2024
Contributor
phillip-stephens
left a comment
phillip-stephens
left a comment
There was a problem hiding this comment.
LGTM, thanks again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DNS probe module now additionally supports options strings like
A:rn,google.com. Thernhas the effect that the "recursion desired" bit will be unset in the respective DNS query packet. If:rnis omitted, the behaviour is not changed (compared to before this update). Therefore, the change maintains backward-compatibility.Examples of supported behaviours:
--probe-args="A,google.com": rd-bit set to 1--probe-args="A:rn,google.com": rd-bit set to 0--probe-args="A,google.com;A:rn,example.org": rd-bit in the query for google.com set to 1, and in the query to example.org set to 0.I have tested these behaviours using the above examples with wireshark.
closes #763
ToDo