Prevent --batch from overflowing the uint8_t it is being stored in#770
Merged
phillip-stephens merged 1 commit intozmap:mainfrom Feb 2, 2024
Merged
Prevent --batch from overflowing the uint8_t it is being stored in#770phillip-stephens merged 1 commit intozmap:mainfrom
phillip-stephens merged 1 commit intozmap:mainfrom
Conversation
Fixes crash for multiples of 256.
phillip-stephens
approved these changes
Feb 2, 2024
Contributor
phillip-stephens
left a comment
phillip-stephens
left a comment
There was a problem hiding this comment.
LGTM, thanks for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents crash for
--batchsizes of multiples of 256, which stored inzconf.batchof typeuint8_tend up as 0./cc @phillip-stephens