Split send-bsd.h into send-mac.h and send-bsd.h and add GitHub action for compiling on FreeBSD/MacOS#771
Conversation
|
Code looks good, though there's been a bunch of commits post you asking for review, so I'm not 100% sure if it's ready to merge. Can you merge when ready? |
|
Yeahhh. Wanted to test my new Github Action to test compiling on FreeBSD on every PR, but the only way to test was to commit and push and run here. Sooooo, hence the 10k commits lol. I did add the #do-not-review label to try to prevent this 😄 |
|
I still have a few things left to do (test using sendmmsg on FreeBSD in a VM), then I'll request a re-review and we can merge. |
|
Sounds good. I missed label 🤦🏽 Usually just look at "Draft" status, but will keep my eye out!! |
phillip-stephens
changed the title
send-bsd.h into send-mac.h and send-bsd.h and add GitHub action for compiling on FreeBSD/MacOS
|
I've realized that BSD handles sockets differently than linux. After taking a stab at figuring out how to port the linux If porting sendmmsg to BSD is a priority, I'll come back to it as a second PR. |
I don't think it is for the core team. If someone else wants to take a look, always happy to accept a PR, but I think that we have a number of more pressing issues. |
This leftover bit was the result of a collision of two in-flight PRs. The last use of _SYSTYPE_BSD was removed along with libdnet in zmap#772, while zmap#771 concurrently added the -D_SYSTYPE_BSD to CMakeLists.txt. _SYSTYPE_BSD is a rather archaic define. libdnet might have used it for compat with now historical systems/compilers, but I do not think it served any purpose beyond that. Certainly, modern FreeBSD, NetBSD and macOS do not reference it. It seems safe to remove.
This leftover bit was the result of a collision of two in-flight PRs. The last use of _SYSTYPE_BSD was removed along with libdnet in #772, while #771 concurrently added the -D_SYSTYPE_BSD to CMakeLists.txt. _SYSTYPE_BSD is a rather archaic define. libdnet might have used it for compat with now historical systems/compilers, but I do not think it served any purpose beyond that. Certainly, modern FreeBSD, NetBSD and macOS do not reference it. It seems safe to remove.
2 participants
send-mac.hfromsend-bsh.hso that each can take advantage of the sys calls available on that OS