Stop defining the now defunct _SYSTYPE_BSD#774
Merged
Conversation
This leftover bit was the result of a collision of two in-flight PRs. The last use of _SYSTYPE_BSD was removed along with libdnet in zmap#772, while zmap#771 concurrently added the -D_SYSTYPE_BSD to CMakeLists.txt. _SYSTYPE_BSD is a rather archaic define. libdnet might have used it for compat with now historical systems/compilers, but I do not think it served any purpose beyond that. Certainly, modern FreeBSD, NetBSD and macOS do not reference it. It seems safe to remove.
zakird
approved these changes
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leftover bit was the result of a collision of two in-flight PRs. The last use of
_SYSTYPE_BSDwas removed along with libdnet in #772, while #771 at the same time added the-D_SYSTYPE_BSDtoCMakeLists.txtin order to remove the need to manually define it when building._SYSTYPE_BSDis a rather archaic define. libdnet might have used it for compat with now historical systems/compilers, but I do not think it served any purpose beyond that. Certainly, modern FreeBSD, NetBSD and macOS do not reference it at all. It seems safe to remove.