Support IP layer mode on FreeBSD and merge Mac with BSD send code#778
Merged
Support IP layer mode on FreeBSD and merge Mac with BSD send code#778
Conversation
Contributor
phillip-stephens
left a comment
phillip-stephens
left a comment
There was a problem hiding this comment.
Looks good overall, just two comments.
cc: @droe
zakird
approved these changes
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--iplayer/-X) on FreeBSD, based on the macOS implementationsrc/send-mac.hcode over tosrc/send-bsd.hand merge, as I think keeping the implementations separate is not worth the code duplicationOriginally I set out to port the sendmmsg code to BSD, but turns out that FreeBSD's sendmmsg is just a libc wrapper around sendmsg, which had escaped my attention when I initially looked into sendmmsg availability. Which of course means sendmmsg would work, but without the perf benefit of less syscall overhead. NetBSD on the other hand does have a proper sendmmsg syscall, but since I do not use NetBSD, I did not undertake the porting.
Tested on macOS Sonoma and FreeBSD 14.