Skip to content

Fix issue in BSD get_hw_addr where last ARP entry would be skipped#779

Merged
zakird merged 1 commit intozmap:mainfrom
droe:droe/fix-get_gateway-bsd-off-by-one
Feb 11, 2024
Merged

Fix issue in BSD get_hw_addr where last ARP entry would be skipped#779
zakird merged 1 commit intozmap:mainfrom
droe:droe/fix-get_gateway-bsd-off-by-one

Conversation

@droe
Copy link
Contributor

@droe droe commented Feb 11, 2024

Fix two off-by-one errors in bounds checks that led to the last rt_msg getting skipped, which sometimes caused zmap to not find the ARP entry for the gateway IP address, depending on its location in the ARP table. Bug introduced in #772.

@zakird zakird merged commit 06d2647 into zmap:main Feb 11, 2024
@droe droe deleted the droe/fix-get_gateway-bsd-off-by-one branch March 11, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants