phillip/781: elevate debug log if can't get a socket on bsd to fatal#783
Merged
phillip/781: elevate debug log if can't get a socket on bsd to fatal#783
Conversation
Contributor
|
Concur failure to create socket should lead to a fatal error, two comments:
|
Contributor
Author
|
@droe appreciate your help with this and lending your knowledge of Linux + BSD networking.
|
Contributor
|
lgtm, thanks — and thanks for bearing with my PRs! |
zakird
approved these changes
Feb 15, 2024
Member
|
looks good, thank you both!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed in testing this PR that if the user forgets
sudo, there were a bunch of errors printed on Mac. @droe had the exact same setup but wasn't seeing this behavior, which is odd. Either way, I think this fix makes sense. If you can't get a socket, you can't send packets, so this should be a fatal error, IMO.