Skip to content

Add a suite of integration tests to Github Actions#789

Merged
zakird merged 14 commits intomainfrom
phillip/dryrun_tests
Feb 26, 2024
Merged

Add a suite of integration tests to Github Actions#789
zakird merged 14 commits intomainfrom
phillip/dryrun_tests

Conversation

@phillip-stephens
Copy link
Contributor

@phillip-stephens phillip-stephens commented Feb 22, 2024

This PR adds a suite of integration tests that run as a Github Action

  • Add a suite of integration tests using --dryrun and validating output for different inputs and CLI flags
  • Add a single "real" scanning test against known "good" IPs: 1.1.1.1 and 8.8.8.8.
  • Add more context to manpages/--help text explaining "target" for -n
  • Adds a Github Action that run these tests

@phillip-stephens phillip-stephens marked this pull request as ready for review February 26, 2024 19:13
@phillip-stephens phillip-stephens added this to the ZMap 4.1 milestone Feb 26, 2024
@phillip-stephens
Copy link
Contributor Author

@zakird I added the tests you suggested, plus some others as well. The one thing I thought was useful but wanted your thoughts was the single "real" scan in test_scan.py that scans 1.1.1.1 and 8.8.8.8. Thought this was valuable, and assuming these IPs don't cease being active as DNS resolvers, should continue to work as designed. But open to suggestions if you disagree.

@zakird zakird merged commit 6cbe1c6 into main Feb 26, 2024
@zakird zakird deleted the phillip/dryrun_tests branch February 26, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants