Use stdbool instead of typedef uint8_t bool in dns probe module#790
Merged
phillip-stephens merged 1 commit intozmap:mainfrom Feb 24, 2024
Merged
Use stdbool instead of typedef uint8_t bool in dns probe module#790phillip-stephens merged 1 commit intozmap:mainfrom
phillip-stephens merged 1 commit intozmap:mainfrom
Conversation
Paves the way for using stdbool in headers that are included by `src/probe_modules/module_dns.c` and allows the removal of undefining bool for NetBSD.
phillip-stephens
approved these changes
Feb 24, 2024
Contributor
phillip-stephens
left a comment
phillip-stephens
left a comment
There was a problem hiding this comment.
LGTM, thanks for the improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert dns probe module to use proper stdbool booleans instead of uint8_t.
Paves the way for using stdbool in headers that are included by
src/probe_modules/module_dns.c, removes the need for undefining bool for NetBSD, and is more consistent with existing other use ofboolin ZMap's codebase.