Skip to content

Fix a number of benign compiler warnings on Linux/GCC#805

Merged
zakird merged 1 commit intozmap:mainfrom
droe:droe/fix-more-compiler-warnings
Mar 3, 2024
Merged

Fix a number of benign compiler warnings on Linux/GCC#805
zakird merged 1 commit intozmap:mainfrom
droe:droe/fix-more-compiler-warnings

Conversation

@droe
Copy link
Contributor

@droe droe commented Mar 3, 2024

src/recv.c:103:17: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
  103 |                 const static uint32_t available_space = sizeof(fake_eth_hdr) - sizeof(struct ether_header);
      |                 ^~~~~

src/if-netmap-linux.c: In function ‘fetch_stats64’: src/if-netmap-linux.c:94:18: warning: ISO C99 doesn’t support unnamed structs/unions [-Wpedantic]
   94 |                 };
      |                  ^

src/probe_modules/packet.h: In function ‘check_dst_port’: src/probe_modules/packet.h:162:37: warning: suggest parentheses around comparison in operand of ‘^’ -Wparentheses]
  162 |                 return (to_validate <= max ^ to_validate >= min);
      |                         ~~~~~~~~~~~~^~~~~~

src/probe_modules/packet.c: In function ‘set_timestamp_option_with_nops’: src/probe_modules/packet.c:178:24: warning: implicit declaration of function ‘time’ [-Wimplicit-function-declaration]
  178 |         uint32_t now = time(NULL);
      |                        ^~~~
src/probe_modules/packet.c:178:24: warning: nested extern declaration of ‘time’ [-Wnested-externs]
  178 |         uint32_t now = time(NULL);
      |                        ^~~~

src/recv.c:103:17: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
  103 |                 const static uint32_t available_space = sizeof(fake_eth_hdr) - sizeof(struct ether_header);
      |                 ^~~~~

src/if-netmap-linux.c: In function ‘fetch_stats64’:
src/if-netmap-linux.c:94:18: warning: ISO C99 doesn’t support unnamed structs/unions [-Wpedantic]
   94 |                 };
      |                  ^

src/probe_modules/packet.h: In function ‘check_dst_port’:
src/probe_modules/packet.h:162:37: warning: suggest parentheses around comparison in operand of ‘^’ -Wparentheses]
  162 |                 return (to_validate <= max ^ to_validate >= min);
      |                         ~~~~~~~~~~~~^~~~~~

src/probe_modules/packet.c: In function ‘set_timestamp_option_with_nops’:
src/probe_modules/packet.c:178:24: warning: implicit declaration of function ‘time’ [-Wimplicit-function-declaration]
  178 |         uint32_t now = time(NULL);
      |                        ^~~~
src/probe_modules/packet.c:178:24: warning: nested extern declaration of ‘time’ [-Wnested-externs]
  178 |         uint32_t now = time(NULL);
      |                        ^~~~
@zakird zakird merged commit 4c36736 into zmap:main Mar 3, 2024
@droe droe deleted the droe/fix-more-compiler-warnings branch March 11, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants