Netmap: fixed ubuntu compilation error by added strlcpy definition to utility.c#808
Merged
phillip-stephens merged 9 commits intomainfrom Mar 6, 2024
Merged
Conversation
…ap/zmap into phillip/netmap-ubuntu-compile
Member
|
We need to be careful on the licensing of this code. Can we use |
Contributor
|
Turns out that strlcpy was added to glibc only very recently, in 2.38, exactly the version that Ubuntu 23.10 ships with, which is why it compiled fine for me on Linux. The |
Contributor
Author
|
Great suggestion @droe, I'll do that. I'll also add some automatic compile check tests for different ubuntu release versions (thinking 18.04+) so we can check for this easier. |
zakird
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was setting up a new Ubuntu VM to test out the Netmap work and was running into compilation errors. Tried a couple of online suggestions (using the
lbsdlinker flag, for example) to no avail. Instead of trying to figure out the linker/CMake, I just thought I'd take thestrlcpyfrom online (Android source code, to be specific) and add that toutility.c. This works and I've confirmed I'm seeing 60% faster packet send on a standard VM than default ZMap. 🎉