+2.9% perf: Avoid copying in send core, further batch memory optimisation#818
Closed
+2.9% perf: Avoid copying in send core, further batch memory optimisation#818
Conversation
Introduce new prepare_packet callback for the initialization of send buffers; contrary to the per-thread initialization callback where this was done previously, prepare_packet can be called multiple times, once for each send buffer. Make use of this to prepare packets to send directly in the batch buffers instead of copying them over.
The ip field was only still used in send-bsd and only on a failure path for logging, which does not seem like a strong justification for keeping it around, especially given that it can always be read from the packet data itself. While removing the ip field, align buf such that the IP header is going to start at a 32 bit aligned address, which again results in 32 bit header field access to be faster because of ideal alignment.
Contributor
Author
|
I broke something, let me come back with this at a later time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ipfield frombatch->packets[]and align the packet data such that the IP headers start at a 32 bit boundary, speeding up 32 bit header field accessThe former results in a ~2% and the latter a further ~0.9% improvement to send rate at 10 GbE on lower-end hardware, while (arguably) improving code structure, or at least not making it worse.
Tested on macOS Sonoma, FreeBSD 14 and Ubuntu 23.10; smoke tested various probe modules.