Conversation
Contributor
Author
|
LMK what you think @zakird or if you see an alternative, nothing immediately sprung to mind. |
zakird
approved these changes
Mar 15, 2024
zakird
requested changes
Mar 15, 2024
Member
zakird
left a comment
zakird
left a comment
There was a problem hiding this comment.
We should change to loop once (call min_d only once)
Contributor
Author
|
Addressed! |
zakird
approved these changes
Mar 16, 2024
This was referenced Mar 18, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #823
Saw with an assert that sometimes, the
remaining_secswas < 0, causing our % remaining calculation to go over 100.I'm not entirely sure how this is happening, but this fix seems both relatively reasonable and sufficient to prevent it happening again.