Conversation
zakird
approved these changes
Apr 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module's
max_packet_lengthis used for accurately computing the send rate to stay under any user-given bandwidth limitations.This bug meant that the packet length was only accurate for the case where no TCP options were used (
--probe-args="none") and incorrect for all other options.Testing
Before fix,
--probe-args="windows" -B 1Gand--probe-args="linux" -B 1Gwould give the same send rate on a non-bandwidth constrained system, even thoughwindowssends 8 bytes less per probe packet.After fix, the same test results in
1.34 Mppsforwindowsand1.24 Mppsforlinux.