Add TCP options parsing in synscan module#858
Merged
phillip-stephens merged 3 commits intozmap:mainfrom Apr 29, 2024
Merged
Conversation
ogasser
force-pushed
the
tcp_options_parsing
branch
from
6417e5f to
0d3bfae
Compare
Member
|
This looks awesome! Excited to get this into ZMap. |
phillip-stephens
approved these changes
Apr 29, 2024
Contributor
phillip-stephens
left a comment
phillip-stephens
left a comment
There was a problem hiding this comment.
Tested out the changes, code looks good and is understandable. LGTM!
phillip-stephens
added a commit
that referenced
this pull request
May 2, 2024
This reverts commit 9971724.
phillip-stephens
added a commit
that referenced
this pull request
May 2, 2024
This reverts commit 4a67cd3.
phillip-stephens
added a commit
that referenced
this pull request
May 3, 2024
* Revert "Revert "Decreased pcap_timeout to prevent monitor issue showing 0 p/s every 43 secs (#862)" (#869)" This reverts commit dadf7e2. * Revert "Add TCP options parsing (#858)" This reverts commit 9971724. * Revert "Revert "Add TCP options parsing (#858)"" This reverts commit 4a67cd3. * sanity check for tcp options length field * break tcp options parsing if length is non-positive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds parsing of the following TCP options (when present) to the
synscanmodule:ts_val)ts_ecr)