Alternative to @2Fast2BCn work. The key design decisions are

• do not use a local cache for banned vtxos. It is complex and adds little
• include is_banned in the is_spendable check
• banning occurs by block-height. This ensures we cannot ban after vtxo expiry by accident

• check or remove this line after you've added a CHANGELOG entry or if your PR doesn't need one (they should go into CHANGELOG/unreleased/)

Ah ok! ALL GOOD THEN ;-)

I was only looking in testing/tests/server/ban.rs 🫣

Kobe Nys (18f0e548) at 17 Mar 08:31

... and 2 more commits

Kobe Nys (b283bfb9) at 17 Mar 08:28

... and 39 more commits

Alternative to @2Fast2BCn work. The key design decisions are

• do not use a local cache for banned vtxos. It is complex and adds little
• include is_banned in the is_spendable check
• banning occurs by block-height. This ensures we cannot ban after vtxo expiry by accident

• check or remove this line after you've added a CHANGELOG entry or if your PR doesn't need one (they should go into CHANGELOG/unreleased/)

There is no test where the ban expired without explicit unban.

Or maybe I missed it.

We aren't trying to find the highest address. We are taking a quick look without changing any of the state.

• check or remove this line after you've added a CHANGELOG entry or if your PR doesn't need one (they should go into CHANGELOG/unreleased/)

Hot damn, totally missed that when looking at this.

Move sccache to dev shell and make it optional (added instructions to CONTRIBUTING.md) .envrc example.

Draft as waiting for !1774 and then a PR to add these variables to CI and then I want to see if that sccache compilation feature is required for it to work.

This one also removed the need to build sccache locally when entering the nix shell.

• check or remove this line after you've added a CHANGELOG entry or if your PR doesn't need one (they should go into CHANGELOG/unreleased/)

Kobe Nys (3d111915) at 16 Mar 14:25

Kobe Nys (584cc8af) at 16 Mar 08:32

... and 25 more commits

Kobe Nys (1bbad22f) at 16 Mar 08:30

Kobe Nys (28cd0e1e) at 13 Mar 22:43

Kobe Nys (7cfb2cfe) at 13 Mar 22:43

... and 1 more commit

Kobe Nys (28cd0e1e) at 13 Mar 22:43