Yes, works now, thanks! :)

Ah, okay, that would make sense, then :)

Cleared the custom compendiums setting. Doesn't help either

Okay, I went as far back as SBC 4.6.5, and none of them worked. I'm pretty sure it used to work with a more recent version than that, so it must be something else than just SBC changes

Some setting? A different module? Compendium shuffling?

Seems to work great now, yes :)

I'm not so sure about the banner popup message for every migrated actor, though. That's very spammy, especially since they stay multiple seconds each, while one actor can be migrated in less than a second. So you have more of them popping up for minutes after the migration is already done, or you need to click-click-click them all away. And that's going to show for every new SBC release, no?

Maybe something like how the PF1e system does it, popping up one wIndow with a progress bar, would be better?

Unfortunately, this does not work. It says:

Uncaught (in promise) TypeError: J.system.details.notes.includes is not a function
[Detected 2 packages: pf1-statblock-converter(5.6.1), lib-wrapper(1.13.2.0)]
    S$ sbcMigration.js:88
    U$ sbcMigration.js:20

Anyway, here's a copy of the "broken" actor data from my backup:

fvtt-Actor-saiya-LXJO9Gz58WOw9n4Y.json

The "notes" with a "value" member of null is at line 51147 in that JSON file there.

Sure, I'll try to find some time tomorrow evening to check that!

Apparently that change in autocomplete-inline-properties was an accident. 3.0.3 restores the old method.

Feel free to close this bug if you don't think moving to the new method is worth it.

No sweat, take care of yourself first :)

Okay, with some added debug output, I traced it to one of my PCs.

notes.value was null on them. The character sheet still displayed the notes tab correctly and empty. Clicking on edit there once (and not saving) corrected it to "". Which makes the migration finish on next log in.

That game has been running since I first migrated from roll20 to Foundry (0.8.x? 0.7.x?) back in 2020? 2021? (I changed my backup scheme for my games end of 2021 and everything before that has been squashed into a single state, so my memory of when what happened is kinda bad), and has been migrated to newer Foundry and PF1e releases continously. I can only guess that that one such update saw the notes to be empty, null is a valid empty value, and the player didn't touch the notes since then.

This means the issue is resolved for me, but it's probably a good idea to liberally use "?." everywhere in the lines 84-87, just to make sure.

Apparently, the way the alt sheet registered with aip has been deprecated for a while (since at least late 2021). Its CONTRIBUTING.MD say:

⚠️ Note: The previous way of adding configurations to game.modules.get("autocomplete-inline-properties").API.PACKAGE_CONFIG during the init hook event is deprecated and will be removed in a future version.

The "new" method to do this is apparently to use the packageConfig parameter passed with the aipSetup hook: https://github.com/farling42/FVTT-Autocomplete-Inline-Properties/blob/main/CONTRIBUTING.md#example

Since that method was introduced so long ago (would be with version 2.5.0 on 2021-10-28), it's probably safe to not even do a version check of aip and do each method, but just move over to the new method altogether.

Okay, migrated my other 2 games too. No issues there.

Only the one here, Falkengrund, breaks. The debugger in Firefox won't let me see the value of actor at that line either. And I can't pop in a quick print into the js file either, because munged. And I don't do that npm dance enough to not forget it each time. Maybe I'll find some time later this evening.

But the exception is thrown from here: https://gitlab.com/foundryvtt_pathfinder1e/pf1-statblock-converter/-/blob/master/scripts/sbcMigration.js?ref_type=heads#L87 , with actor.system.details.notes.value being null.

It doesn't. Or am I missing something?

sbc-pf1 | Updating custom compendiums 
sbcUtils.js:100:17
sbc-pf1 | Initializing sbc v5.6.1 
@https://falkengrund.dmcrpg.de/modules/pf1-statblock-converter/scripts/sbc.js:39:22154 sbcUtils.js:100:17
Array(16) [ "pf-content.pf-items", "pf-content.pf-magicitems", "pf-content.pf-wondrous", "pf1.weapons-and-ammo", "pf1.armors-and-shields", "pf1.races", "pf1.racialhd", "pf1.classes", "pf1.feats", "pf1.items", … ]
sbc.js:155:12
sbc-pf1 | Registering default compendia... 
processCompendiums@https://falkengrund.dmcrpg.de/modules/pf1-statblock-converter/scripts/sbc.js:1:781 sbcUtils.js:100:17
sbc | Config initialized sbc.js:60:10
sbc | Migration started... foundry.js:72077:78
Uncaught (in promise) TypeError: J.system.details.notes.value is null
[Detected 1 package: pf1-statblock-converter(5.6.1)]
    S$ sbcMigration.js:87
    U$ sbcMigration.js:20

In one of my other games, SBC Migration throws an exception:

Uncaught (in promise) TypeError: J.system.details.notes.value is null
[Detected 1 package: pf1-statblock-converter(5.6.1)]
    S$ sbcMigration.js:87
    U$ sbcMigration.js:20