Hi @Bigginz87

Those changes look fine.

@megadjc

Is this board on the radar for the LID change?

The count buffer[06] and remaining buffer[07] don't look to be used zone 04

Why would those changes be needed?

Interesting, do you still have the captures for those?

Then this will need to be checked to ensure it doesn't break existing layouts.

Do you need to set this here if you set it again on ln 308?

Is this change required?? If so it will impact more than just your laptop variant and will need to be tested for regression.

This code is redundant. Please remove and set the power config from the settings. See SetPowerConfigFromJSON()

Please rewrite this to start the FULL_SIZE layout

Hi @aventin,

This device looks like it's using feature page 8070 and should go into the common Logitech controller.

Hi @ToastKiste211

This device should be added to the CorsairV2protocol which admittedly probably still needs some work.

Looking for the link you send-me, I cant see what was missing. May you help?

Per my previous comment you are likely missing the kernel parameter fix specific to Gigabyte motherboards. If you're having trouble with the linked page I would suggest using the browser find function ctrl-f for gigabyte as you will likely want the documented instructions specific to Fedora.

Hi @jgardona

It would first check that you are running the v1.0rc2 or later version of OpenRGB. openrgb --version. Did you install the official .rpm for F43?

I suspect you have not added the required kernel parameter that is documented here. You can confirm the parameters that the running kernel was booted with by entering cat /proc/cmdline in a terminal.

You should edit this into the description so that it closes the issue when merged.

Hi @FransM

Given the timing on sending this data packet can these lines just be added to the constructor and we can avoid the public function altogether?

Ok, looks good. I assume that everything is working correctly now? If so it's ready to remove the draft status.

Ok, at the moment this change will be added to all regional layouts where as I think you likely want to avoid applying it to an ANSI keyboard so it should go into the section labelled /* Add more regional layout fixes here */

    KEYBOARD_SIZE_SEVENTY_FIVE,
    {
        akko_5075_ISO_values,
        {
            {
                KEYBOARD_LAYOUT_ISO_QWERTY,
                /*-------------------------------------------------------------------------------------------------------------------------------------*\
                | Edit Keys                                                                                                                             |
                |   Zone,   Row,    Column,     Value,      Key,                        Alternate Name,             OpCode,                             |
                \*-------------------------------------------------------------------------------------------------------------------------------------*/
                {   0,      3,      13,           0,        KEY_EN_UNUSED,              KEY_EN_UNUSED,              KEYBOARD_OPCODE_REMOVE_SHIFT_LEFT,  },  // Remove ANSI Enter
                {   0,      2,      13,          80,        KEY_EN_ISO_ENTER,           KEY_EN_UNUSED,              KEYBOARD_OPCODE_INSERT_SHIFT_RIGHT, },  // Insert ISO Enter

            }
            /* Add more regional layout fixes here */
        }
    },

Ok, sure. The way I read these 2 operations you're removing the Right CTRL and replacing it in the same spot. Seems redundant but it might be because the layout above is expected to have the full set of ANSI / ISO keys.

If you run OpenRGB with --loglevel 6 it will dump the KLM construction into the log which can be helpful for debugging.

That makes sense to me. If you take a look at the snippet of the linked code

        switch(device->modes[selected_mode].color_mode)
        {
            case MODE_COLORS_PER_LED:
            {
                ui->DeviceViewBox->setSelectionColor(rgb_color);
                break;
            }

            case MODE_COLORS_MODE_SPECIFIC:
            {
                unsigned int index = ui->LEDBox->currentIndex();

                device->modes[selected_mode].colors[index] = rgb_color;
                device->UpdateMode();
                break;
            }

Per LED colour and mode specific would take different code paths here. MODE_COLORS_PER_LED should assign the colors vector for the selected LEDs from the LEDview or the LEDBox. When the mode is MODE_COLORS_MODE_SPECIFIC the LEDBox lists mode specific colours which if you have declared only 1 and the LEDBox will be disabled.

This should not be needed if the ANSI / ISO layout template is filled as mentioned.