GeneralProtocols activity https://gitlab.com/GeneralProtocols 2026-03-17T07:19:41Z tag:gitlab.com,2026-03-17:5211272483 Jonathan Silverblood commented on issue #49 at GeneralProtocols / XO / engine 2026-03-17T07:19:41Z monsterbitar Jonathan Silverblood

it seems reasonable to me that commits with non-authorized data would not be shared to other role-holders before first being returned to the party that can do the authorization.

Even if it does, that would still be fine as blame can clearly be laid at the party claiming a role and then not signinf off on the data, either because:

  1. if you disregard the data then there is unfullfilled requirements, or
  2. if you consider the data then there is a party that hasn't yet signed

So it comes down to the question of "did entity X call signInivitation()?"

If they did, but didn't sign the other data, then that data is to be disregarded (treat it as it simply wasn't there). If they didn't, then treat treat the invitation as non-complete as a role requirement still remains to be fullfilled.

tag:gitlab.com,2026-03-16:5207645706 Kuldeep deleted project branch upgrade/pipeline-config at GeneralProtocols / XO / templates 2026-03-16T10:55:45Z kiok46 Kuldeep

Kuldeep (d96fd422) at 16 Mar 10:55

tag:gitlab.com,2026-03-16:5207645517 Kuldeep pushed to project branch development at GeneralProtocols / XO / templates 2026-03-16T10:55:42Z kiok46 Kuldeep

Kuldeep (85fa7d53) at 16 Mar 10:55

Merge branch 'upgrade/pipeline-config' into 'development'

... and 1 more commit

tag:gitlab.com,2026-03-16:5207645514 Kuldeep accepted merge request !4: Add pipeline, fix audit and update project configs at GeneralProtocols / XO / templates 2026-03-16T10:55:42Z kiok46 Kuldeep
tag:gitlab.com,2026-03-16:5207634809 Jonathan Silverblood approved merge request !4: Add pipeline, fix audit and update project configs at GeneralProtocols / XO / templates 2026-03-16T10:53:34Z monsterbitar Jonathan Silverblood
tag:gitlab.com,2026-03-16:5206924732 Kuldeep pushed to project branch upgrade/pipeline-config at GeneralProtocols / XO / templates 2026-03-16T08:10:28Z kiok46 Kuldeep

Kuldeep (d96fd422) at 16 Mar 08:10

Update to latest version of types

tag:gitlab.com,2026-03-16:5206869703 Kuldeep deleted project branch feat/output-role at GeneralProtocols / XO / types 2026-03-16T07:55:05Z kiok46 Kuldeep

Kuldeep (8f331af2) at 16 Mar 07:55

tag:gitlab.com,2026-03-16:5206869612 Kuldeep pushed to project branch development at GeneralProtocols / XO / types 2026-03-16T07:55:03Z kiok46 Kuldeep

Kuldeep (68cdf949) at 16 Mar 07:55

Merge branch 'feat/output-role' into 'development'

... and 1 more commit

tag:gitlab.com,2026-03-16:5206869586 Kuldeep accepted merge request !17: Add role view properties to outputs at GeneralProtocols / XO / types 2026-03-16T07:55:03Z kiok46 Kuldeep
tag:gitlab.com,2026-03-16:5206812865 Jonathan Silverblood approved merge request !17: Add role view properties to outputs at GeneralProtocols / XO / types 2026-03-16T07:37:43Z monsterbitar Jonathan Silverblood
tag:gitlab.com,2026-03-16:5206809144 Jonathan Silverblood commented on merge request !4 at GeneralProtocols / XO / templates 2026-03-16T07:36:33Z monsterbitar Jonathan Silverblood

approved now so that I can see in the log that I have reviewed and approved this earlier and can re-review only the changes.

tag:gitlab.com,2026-03-16:5206808255 Jonathan Silverblood approved merge request !4: Add pipeline, fix audit and update project configs at GeneralProtocols / XO / templates 2026-03-16T07:36:14Z monsterbitar Jonathan Silverblood
tag:gitlab.com,2026-03-16:5206802809 Jonathan Silverblood commented on merge request !4 at GeneralProtocols / XO / state 2026-03-16T07:34:18Z monsterbitar Jonathan Silverblood

I assume these either are no longer needed, or have been moved elsewhere prior to this MR.

tag:gitlab.com,2026-03-16:5206797472 Jonathan Silverblood commented on merge request !4 at GeneralProtocols / XO / state 2026-03-16T07:32:38Z monsterbitar Jonathan Silverblood

this creates two storage adapters.

I assume it's better to do "const storageAdapterPromise = createStorageAdapter(...);

then await expect(storageAdapterPromise...

tag:gitlab.com,2026-03-16:5206789848 Jonathan Silverblood commented on merge request !4 at GeneralProtocols / XO / state 2026-03-16T07:29:49Z monsterbitar Jonathan Silverblood

./ doesn't seem like a temp directory.

tag:gitlab.com,2026-03-16:5206785266 Jonathan Silverblood commented on merge request !4 at GeneralProtocols / XO / state 2026-03-16T07:28:07Z monsterbitar Jonathan Silverblood

maximum of 1 here, but checks in this MR compare against both >1 and >2

tag:gitlab.com,2026-03-15:5205342375 Emergent Reasons commented on merge request !6 at GeneralProtocols / XO / utils 2026-03-15T14:07:06Z emergent-reasons Emergent Reasons

.... 🤔 if libauth is handling bigints and uint8arrays, and we are going to use that standard, then... why do we need a separate extended-json package?

tag:gitlab.com,2026-03-15:5205340157 Emergent Reasons commented on merge request !6 at GeneralProtocols / XO / utils 2026-03-15T14:04:51Z emergent-reasons Emergent Reasons

This was me being dumb.

tag:gitlab.com,2026-03-15:5205317996 Kuldeep commented on merge request !6 at GeneralProtocols / XO / utils 2026-03-15T13:46:19Z kiok46 Kuldeep

It uses a replacer https://github.com/bitauth/libauth/blob/master/src/lib/format/log.ts#L27

tag:gitlab.com,2026-03-15:5205314815 Emergent Reasons commented on merge request !6 at GeneralProtocols / XO / utils 2026-03-15T13:42:44Z emergent-reasons Emergent Reasons

If I understand correctly, this will still fail on bigints due to libauth currently still using base JSON.stringify.