LukeWH (0fd2cd64) at 31 Jul 15:01

LukeWH (0fd2cd64) at 31 Jul 13:18

LukeWH (92f87d76) at 26 Jul 10:29

LukeWH (37d4cea2) at 26 Jul 10:20

Intent

To show custom Net Architectures in Characters Gear list

---

• This is meant for a hotfix
• This is meant for the next release (see milestone)
• This needs more reviewers than normal; there may be controversy or high complexity
• This intentionally introduces regressions that will be addressed later
• There is/will be documentation changes on the wiki
• Please do not send commits here without coordinating closely with the owner
• This is a Build System change

Related Issues

• #1022

Steps to Test

1. Create new custom net architecture item
2. Open a character sheet
3. Drag the item onto the character sheet
4. See the net architecture appended to the bottom of the gear list under "Net Architecture"

Future Work

Possibly hide the Net Architecture category until a Net Architecture is on a character sheet to keep things clean.

Additional Notes

LukeWH (92f87d76) at 26 Jul 10:09

LukeWH (213cbe37) at 26 Jul 10:09

... and 64 more commits

LukeWH (f62949c8) at 11 Jul 15:49

LukeWH (f62949c8) at 11 Jul 15:49

... and 2 more commits

Intent

Prevent duplicate bonuses being applied and displayed to the user, also deduping all modifications on roll, based on the mods ID.

---

• This is meant for a hotfix
• This is meant for the next release (see milestone)
• This needs more reviewers than normal; there may be controversy or high complexity
• This intentionally introduces regressions that will be addressed later
• There is/will be documentation changes on the wiki
• Please do not send commits here without coordinating closely with the owner
• This is a Build System change

Related Issues

• #1017

Steps to Test

Follow the steps as described in #1017:

1. Create Active Effect with Autofire skill bonus (provided below).
2. Equip weapon and roll an Autofire attack.
3. Observe the duplication of the Active Effect Bonus by hovering the mouse over the Total Mods: bonus in the attack roll dialogue window (images provided below)

Future Work

Currently there are two paths, one for collecting mods for the actual roll, and another for initial calculation to break down the mods to display to the user. These should probably use the same code path to avoid deviating logic. I could have added checks to each part of CPRMod.getSituationalRollMods() but this seemed like a lot of extra code and this method is big, complex, and scary already.

Additional Notes

[Type text here]

I've updated the code considering what you've said. As it's the only one that's duplicated deduping all mods seems overkill from a performance perspective using either reduce or map so I've refactored to do a more basic check to the second instance that the autofire mod is added with a big old comment above to explain.

LukeWH (74957a31) at 01 Jul 08:29

Intent

Fixes some theming issue when using Dark Mode and the MATT module.

---

• This is meant for a hotfix
• This is meant for the next release (see milestone)
• This needs more reviewers than normal; there may be controversy or high complexity
• This intentionally introduces regressions that will be addressed later
• There is/will be documentation changes on the wiki
• Please do not send commits here without coordinating closely with the owner
• This is a Build System change

Related Issues

• #998

Steps to Test

1. Checkout / Build / Load
2. Install/Activate Monk's Active Tile Triggers Module
3. Enable Dark Mode theme
4. Add a Tile to a Scene
5. Edit Tile
6. Switch to Triggers tab
7. Edit things and make sure things remain readable

LukeWH (fd5e48c3) at 27 Jun 14:13

Intent

Prevent duplicate bonuses being applied and displayed to the user, also deduping all modifications on roll, based on the mods ID.

---

• This is meant for a hotfix
• This is meant for the next release (see milestone)
• This needs more reviewers than normal; there may be controversy or high complexity
• This intentionally introduces regressions that will be addressed later
• There is/will be documentation changes on the wiki
• Please do not send commits here without coordinating closely with the owner
• This is a Build System change

Related Issues

• #1017

Steps to Test

Follow the steps as described in #1017:

1. Create Active Effect with Autofire skill bonus (provided below).
2. Equip weapon and roll an Autofire attack.
3. Observe the duplication of the Active Effect Bonus by hovering the mouse over the Total Mods: bonus in the attack roll dialogue window (images provided below)

Future Work

Currently there are two paths, one for collecting mods for the actual roll, and another for initial calculation to break down the mods to display to the user. These should probably use the same code path to avoid deviating logic. I could have added checks to each part of CPRMod.getSituationalRollMods() but this seemed like a lot of extra code and this method is big, complex, and scary already.

Additional Notes

[Type text here]

LukeWH (6a4798e3) at 27 Jun 13:38

... and 122 more commits

I've confirmed this bug, going to take a look

LukeWH (bc28e052) at 27 May 14:37