Norman Debald (9f8662ce) at 17 Mar 16:53

... and 1923 more commits

@thiagocsf So you mean my already closed MR suggestion has maybe a second chance?

Norman Debald (b2d1c00f) at 16 Mar 22:24

... and 12 more commits

u r welcome

Norman Debald (a3baf42e) at 16 Mar 21:20

... and 1912 more commits

Thanks for the review @kherman1! I've added unit tests for the onScroll behavior as requested. The tests cover both scenarios (with and without frequently_used category) and verify that the correct tab is highlighted at various scroll offsets. Let me know if there's anything else you'd like me to adjust!

Norman Debald (beb7cf40) at 16 Mar 21:18

Done! Refactored to use validate_numericality_of with a scoped :code_coverage subject, following the existing pattern in this spec. Feature flag gating test kept separate.

Norman Debald (38c6e907) at 16 Mar 20:53

Fixed in MR1. Since this is a stacked MR and the feature flag file is actually introduced in !226363 (MR1, not MR2), I pointed introduced_by_url to !226363.

Tried removing the actor, but RuboCop (Gitlab/FeatureFlagWithoutActor) enforces an explicit actor. Kept project to stay compliant.

Fixed in MR1, new migrations use '18.11'.

Fixed in MR1, updated to '18.11'.

Acknowledged. As a community contributor, could someone from the team create the rollout issue? Happy to add the URL once it exists.

Resolved by the split: each migration now matches its table name.

Added CHECK constraints for both tables in a separate migration in MR1. Regarding float vs decimal: happy to defer to the team as you suggested, since CI coverage values are already floats.

Agreed! The migration touched two tables which triggers RequireDisableDdlTransactionForMultipleLocks, so instead I split it into two separate migrations (one per table) in MR1. No disable_ddl_transaction! needed anymore.

Norman Debald (acadb6a7) at 16 Mar 20:31

Hi @reza-marandi Thank you I will take a look at soon as possible.