@ibraheem.farooq IIUC, considering AiveroSampler-x86_64-nightly- 2ea14042, the commit being used is 2ea14042. That does not have any of the work which is part of this MR. Commit should be af3817d5. Can you please recheck using a latest image?

Is there any feedback from testing with the changes to rgbdmux?

Should produce the appimage I believe as this was rebased on top of !9 (merged) and now main.

Depends on !9.

Sorry for the noise/separate MR. !22 (merged) will suffice.

@raffael_santi This is now rebased on top of Amy's work in !9 (merged) and includes all of WP1, WP2, WP3 and WP3a. Top 19 commits on top of !9 (merged).

I am not sure about CI failures. Also, would be good to have feedback, if everything works as per specifications in #11.

Sanchayan Maity (af3817d5) at 11 Mar 11:42

... and 166 more commits

Rebased/cherry-picked version on top of !9 (merged).

• Fix Rust edition 2024 Never Type Fallback Errors
  These errors are caused by Rust 2024's changes to never type (!) fallback. Compiler can't infer the type for a generic parameter that defaults to ! (the never type) in Rust 2024.

  Follow the compiler's suggestions exactly. Add () type annotation to the generic calls.

• Update Cargo.lock file for tauri & tauri deps
  Tauri being very picky about dependencies, the build fails due to a mismatch between tauri version on node and Rust. Use Cargo.lock to pin the Rust versions and specify exact versions on node side.

• src-tauri: Format Rust files

• src-tauri: Clean up all warnings

• gst-rgbd: Format rust files

• frame_dumping: Reduce the number of overruns
  We see quite a lot of overruns. Set up the queue properties and just use a high enough value for max-size-time. This reduces the overruns by a lot but does not get rid of them completely. Ideally should decide the queue sizes somehow based on the expected frame rate and data flow.

  We also change the pipeline slightly by dropping the queue in front of the tee and adding a queue before the file sink.

• gst-rgbd/rgbdmux: Minor clean ups

• gst-rgbd/rgbdmux: Introduce stream-name as a property on sink pad
  We introduce a new pad property on aggregator sink pads for storing stream name and use it later on. This allows us to decouple the usage of stream name from pad request. The stream name is determined on the basis of source pads upstream to rgbdmux like src_color which was then use for sink pad naming on rgbdmux in the format sink_color_<camera-name> when requesting pads.

  This will allow us to request pad early on but set the stream name via a property on the pad later and link the pad only after all pads have been requested first. See the next commit for how this is used to fix missing frames in recording sessions.

• aivero-sample: Fix missing frames in recording sessions

Closing in favor of !23 (closed).

Depends on !9.

Sanchayan Maity (5f3c1477) at 11 Mar 10:52

... and 122 more commits

Sanchayan Maity (5dee384f) at 11 Mar 10:01

... and 1 more commit

Sanchayan Maity (09e20a8a) at 10 Mar 12:19

Sanchayan Maity (f453b79d) at 10 Mar 11:57

... and 1 more commit

Sanchayan Maity (a0442785) at 09 Mar 15:57

... and 1 more commit

Sanchayan Maity (9c8fdb64) at 06 Mar 12:42

Sanchayan Maity (a9bbee43) at 06 Mar 09:18

... and 1 more commit

This MR is based on top of os-40-port-mr-for-rebased-aivero-sampler branch.