Subhadip activity https://gitlab.com/Subhadiptech 2023-05-02T04:48:07Z tag:gitlab.com,2023-05-02:2563729504 Subhadip commented on issue #431 at aossie / Agora-Android 2023-05-02T04:48:07Z Subhadiptech Subhadip

Some misunderstanding related to this issue. Actually I was pointing out the size of the edittext and button together. As it's the UI, we can close this issue

tag:gitlab.com,2023-04-30:2562198370 Subhadip opened merge request !479: Updated deprecated codes at aossie / Agora-Android 2023-04-30T21:33:03Z Subhadiptech Subhadip

Fixes #451

Changes :

  • Removed old and deprecated code as much possible
  • Removed unnecessary null checks
  • Function Typo's

Screenshots for the change :

Many Many changes

tag:gitlab.com,2023-04-30:2562196725 Subhadip opened issue #453: [Code Improvement] Updating deprecated InternetManager at aossie / Agora-Android 2023-04-30T21:28:28Z Subhadiptech Subhadip

Describe the chore :

Updating deprecated InternetManager to new code

Would you like to work on the issue?

@hackeramitkumar Already working on it and soon attach a MR.

tag:gitlab.com,2023-04-30:2562196402 Subhadip opened issue #452: [Code Improvement] Update deprecated permission handlers to new ones at aossie / Agora-Android 2023-04-30T21:27:25Z Subhadiptech Subhadip

Describe the chore :

Update the onActivityCreated and permission handlers as they are deprecated.

Would you like to work on the issue?

@hackeramitkumar Have started working on it and soon attach a MR

tag:gitlab.com,2023-04-30:2562163631 Subhadip opened issue #451: [Code Quality Enhancement] Deprecated Code Updation at aossie / Agora-Android 2023-04-30T20:01:00Z Subhadiptech Subhadip

Describe the chore :

There are many code snippets which are un-necessary, some deprecated and could be made simpler.

Would you like to work on the issue?

@hackeramitkumar I am already working on this issue and soon attach an MR.

tag:gitlab.com,2023-04-29:2561425203 Subhadip opened issue #449: [UX Implementation] Privacy Policy and Terms and Conditions clicks not implemented at aossie / Agora-Android 2023-04-29T12:37:32Z Subhadiptech Subhadip

Describe the feature you'd like :

On clicking Terms and condition or Privacy Policy button, no action is performed on client side. This is due to the unhandled clicks. This needs to be removed or fixed in a proper way to prevent bad user experience.

Additional context :

  • Need to make Terms and Conditions and privacy policy page. We can generate this using some sort of AI, or we can redirect to the README.md and we can add the text there.

Screenshots :

Referring these 2 buttons:

WhatsApp_Image_2023-04-29_at_6.06.27_PM

We can see no clicks are handled.

Screenshot_2023-04-29_at_6.06.07_PM

Would you like to work on the issue?

@hackeramitkumar I have started working on this and soon make a MR.

tag:gitlab.com,2023-04-27:2558537262 Subhadip opened merge request !477: Updated Base URL at aossie / Agora-Android 2023-04-27T21:02:00Z Subhadiptech Subhadip

Fixes #447

Changes :

tag:gitlab.com,2023-04-26:2556028311 Subhadip opened issue #447: Update BASE_URL of the client at aossie / Agora-Android 2023-04-26T23:42:55Z Subhadiptech Subhadip

Describe the feature you'd like :

The base url, the app currently using is the old backend which has been changed. It should be changed to make sure the app works

Screenshots :

null

Would you like to work on the issue?

@hackeramitkumar I will make an MR soon

tag:gitlab.com,2023-04-24:2548647574 Subhadip opened merge request !476: Removed onBackPressed Deprecation at aossie / Agora-Android 2023-04-24T11:31:27Z Subhadiptech Subhadip

Fixes #446

Changes :

  • Changes refers to MainActivity.kt
  • Removed onBackPress handler as it was deprecated
  • Added new back press handler named onBackPressedDispatcher callback

Screenshots for the change :

Screenshot_2023-04-24_at_5.01.06_PM

tag:gitlab.com,2023-04-24:2548640750 Subhadip opened issue #446: [Deprecated Code] Replaced onBackPress handler with onBackPressedDispatcher callback implementation at aossie / Agora-Android 2023-04-24T11:28:35Z Subhadiptech Subhadip

Describe the bug :

onBackPress handler is now deprecated. For Ref

Expected Behaviour :

No behaviour change. Just code improvements

Steps to reproduce it :

Nil

LogCat for the issue :

Not an issue

Screenshots of the issue :
Screenshot_2023-04-24_at_4.52.12_PM

Smartphone Info :

Device Redmi Note 8
Android Version Android 11

Would you like to work on the issue?

I have already resolved this issue and will attach MR to it.

tag:gitlab.com,2023-04-12:2526865245 Subhadip commented on issue #433 at aossie / Agora-Android 2023-04-12T21:28:05Z Subhadiptech Subhadip

Sure

tag:gitlab.com,2023-04-12:2526656048 Subhadip opened merge request !475: Fixed Logics for collecting multiple flows inside lifecycle scope. at aossie / Agora-Android 2023-04-12T19:10:55Z Subhadiptech Subhadip

Fixes #444

Changes :

  • Added repeatOnLifecycle() dependencies (implementation "androidx.lifecycle:lifecycle-runtime-ktx:2.4.0")
  • Added logics for collecting multiple flows as:

`

  lifecycleScope.launch {
        repeatOnLifecycle(Lifecycle.State.STARTED) {
           
            launch {
                flow1.collect { /* Handle */ }   
            }
            launch {
                flow2.collect { /* Handle */ }
            }
            launch {
                flow3.collect { /* Handle */ }
            }
        }
    }

`

Screenshots for the change :

Screenshot_2023-04-13_at_12.39.33_AM

Appetize link: https://appetize.io/app/x63j237cj2tjzgfwtv5fvk5qxa?device=pixel4&osVersion=11.0&scale=75

tag:gitlab.com,2023-04-12:2526636033 Subhadip opened issue #444: [Logical Issue] Unreachable code for collecting flow CastVoteActivity.kt at aossie / Agora-Android 2023-04-12T18:59:03Z Subhadiptech Subhadip

Describe the bug :

With reference to the code from CastVoteActivity.kt: Line:186 to Line:211 is unreachable as we cannot collect multiple flows inside a single lifecycle coroutine scope. Calling collect on a Flow suspends the coroutine until the Flow is complete. For a MutableStateFlow, it will only be complete when it's cancelled. So usually, doing so will execute only the first flow and program never reaches to next flow.

Expected Behaviour :

All the flows should be collected. For this we have to use repeatOnLifecycle(Lifecycle.State.STARTED) and inside this block we have to collect all the flows.

Steps to reproduce it :

LogCat for the issue :

Screenshots of the issue :
Screenshot_2023-04-13_at_12.21.30_AM

Smartphone Info :

Device Redmi Note 8
Android Version Android 11

Would you like to work on the issue?

I have fixed this issue and attached a PR already. @ABHI165 @hackeramitkumar Kindly review this.

tag:gitlab.com,2023-04-08:2518808388 Subhadip commented on merge request !472 at aossie / Agora-Android 2023-04-08T11:20:02Z Subhadiptech Subhadip

@hackeramitkumar Done

tag:gitlab.com,2023-04-04:2510609884 Subhadip opened merge request !472: Fixed alignment issue on about screen [FIX #434] at aossie / Agora-Android 2023-04-04T13:45:05Z Subhadiptech Subhadip

Fixes #434

Changes :

  • removed horizontal bias and added proper constraints to the textview
  • Gave some margins on horizontal of the textview

Screenshots for the change :
Before: Screenshot_2023-04-04_at_7.37.58_PM

After: WhatsApp_Image_2023-04-04_at_7.38.37_PM

App Link: https://appetize.io/app/x63j237cj2tjzgfwtv5fvk5qxa?device=pixel4&osVersion=11.0&scale=75

tag:gitlab.com,2023-04-04:2510594556 Subhadip opened merge request !471: Handled the UI for different internet states Fix #439 at aossie / Agora-Android 2023-04-04T13:40:19Z Subhadiptech Subhadip

Fixes #439

Changes :

  • Broadcast receiver has been implemented to listen the network state change and according handle the UI
  • We have a non-cancellable dialog, which pops up when there is no internet and dismisses when the internet arrives.

Screenshots for the change :

tag:gitlab.com,2023-04-04:2510574299 Subhadip opened merge request !470: updated base url to new backend at aossie / Agora-Android 2023-04-04T13:33:59Z Subhadiptech Subhadip

Fixes #438

Changes :
Updated the base url from: https://agora-rest-api.herokuapp.com/api/v1/__ to https://agora-378510.uc.r.appspot.com/api/v1/__

tag:gitlab.com,2023-04-04:2510562650 Subhadip opened merge request !469: Upgraded Facebook login SDK at aossie / Agora-Android 2023-04-04T13:30:25Z Subhadiptech Subhadip

Fixes #443

Changes :

  • Changed the facebook SDK version from 5.2.0 to 8.2.0

Screenshots for the change :

Before: Screenshot_2023-04-04_at_6.32.33_PM

After: Screenshot_2023-04-04_at_6.34.22_PM

tag:gitlab.com,2023-04-04:2510501459 Subhadip created project Subhadip / Agora-Android 2023-04-04T13:11:21Z Subhadiptech Subhadip tag:gitlab.com,2023-04-04:2510497026 Subhadip closed merge request !464: Handled the UI for different internet states Fix #439 at aossie / Agora-Android 2023-04-04T13:09:59Z Subhadiptech Subhadip

[Fix] Handled the UI according to internet states #439

Changes :

  • Broadcast receiver has been implemented to listen the network state change and according handle the UI
  • We have a non-cancellable dialog, which pops up when there is no internet and dismissed when the internet arrives.

Screenshots for the change :

I am sharing the video of the change: