@dpisek let's assume the migration isn't happening for now 🙏

AJ Biton (0c44d221) at 10 Mar 16:42

... and 1424 more commits

Thanks folks @schmil.monderer @mfanGitLab - I think let's merge this for now 👍

Nice one @charlieeekroon! I'm assuming we have confirmed with SCA there would be no adverse effects as a result of doing this? 🙏

Just looping in @beckalippert as well who was involved in the banner cleanup effort, as I'm not sure if there are new 'guidelines' we should be following. 🙏 We have a plan to introduce a "notification drawer" to replace banners on sec pages, but that's not going to make it into %18.10.

Hey @mfanGitLab @schmil.monderer,

Thank you both for contributing to this never-ending bug! I think one of the challenges we face is that this area of the code is fairly misunderstood and there is currently no short-term plan to address it all the improvements noted in the various threads in the past few weeks.

I've gone ahead and opened MR Security Widget Implementation Improvements (#592403) where we can start tracking important discussions and improvements which we can eventually formalise into a plan.

Let's await to see if we get more feedback, although I suspect the context-switch might be costly for some. If we don't get a response by EOW, I'm happy to book 30 mins in the cal for Monday so we can reach a quick decision here with minimal async cost.

AJ Biton (f471747e) at 05 Mar 10:57

... and 1 more commit

AJ Biton (3431e7b2) at 05 Mar 10:56

Thanks for your interest in becoming a database reviewer! Database reviewers are like backend reviewers but with a special focus on the database. As a result, there are some special challenges they may face in the course of their necessary work.

Before becoming a database reviewer, we ask that you complete the following steps to be sure you're prepared!

New reviewer tasks

• Change merge request to include your name: Add Database Reviewer: Your Name
• Review general code review guidelines
• Familiarize yourself with how to review for database
• Ask to be added to @gl-database, this handle is used to inform and consult with database folks about updates to the database review process.
• Read Understanding EXPLAIN plans
• Read up on what to do if you're feeling overwhelmed by database reviews
• Optional (but recommended): Open an access request for (if you don't have them already):
  • AllFeaturesUser access in postgres.ai
  • The db-lab chef role for psql access to database lab
  • Developer role in the ops testing pipeline project.
• Mention the database team manager for awareness: @alexives for visibility
• Assign the issue to your manager to merge

Note that approving and accepting merge requests is restricted to Database Maintainers only. As a reviewer, pass the MR to a maintainer for approval.

Where to go for questions?

Reach out to #database on Slack

Thanks for your interest in becoming a database reviewer! Database reviewers are like backend reviewers but with a special focus on the database. As a result, there are some special challenges they may face in the course of their necessary work.

Before becoming a database reviewer, we ask that you complete the following steps to be sure you're prepared!

New reviewer tasks

• Change merge request to include your name: Add Database Reviewer: Your Name
• Review general code review guidelines
• Familiarize yourself with how to review for database
• Ask to be added to @gl-database, this handle is used to inform and consult with database folks about updates to the database review process.
• Read Understanding EXPLAIN plans
• Read up on what to do if you're feeling overwhelmed by database reviews
• Optional (but recommended): Open an access request for (if you don't have them already):
  • AllFeaturesUser access in postgres.ai
  • The db-lab chef role for psql access to database lab
  • Developer role in the ops testing pipeline project.
• Mention the database team manager for awareness: @alexives for visibility
• Assign the issue to your manager to merge

Note that approving and accepting merge requests is restricted to Database Maintainers only. As a reviewer, pass the MR to a maintainer for approval.

Where to go for questions?

Reach out to #database on Slack