Allison Browne activity

Allison Browne approved merge request !222593: Show environment block on any environment:action job at GitLab.org / GitLab

2026-03-02T19:31:05Z

What does this MR do and why?

Show environment block on any environment:action job's details page.

Instead of showing the environment block with the linked environment on deploy jobs only (environment:action = start, show it on any action that accesses the environment (on any environment:action value).

Changelog: changed

References

Access an environment for preparation or verification purposes

Screenshots or screen recordings

Before	After

How to set up and validate locally

Have a local GitLab runner installed and registered on your development environment.
Create a CI configuration file with different environment:action values for each job. Sample file: sample-gitlab-ci.yml
When the job finishes, go to it's details page.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #450878

Allison Browne commented on merge request !223444 at GitLab.org / GitLab

2026-02-27T17:40:12Z

@rcobb, can you do the first review?

Allison Browne pushed to project branch ab-fix-bbm-attribution at GitLab.org / GitLab

2026-02-27T14:56:26Z

Allison Browne (a8dd6d17) at 27 Feb 14:56

Fix spec/lib/gitlab/sidekiq_death_handler_spec.rb spec

Allison Browne commented on issue #584179 at GitLab.org / GitLab

2026-02-27T14:49:31Z

TODO before leave: Add json for grafana dash or MR for grafana dash I've been working on

Allison Browne commented on merge request !10082 at GitLab.com / Runbooks

2026-02-27T14:20:41Z

@sxuereb, I'm very grateful for the reviews

Allison Browne commented on merge request !2757 at GitLab.org / cli

2026-02-27T14:17:25Z

@thisisrick25, I'm heading out on parental leave so I re-ran the danger bot to re-run the review roulette. If you are able to make updates you can mention @erren for the next review cycle.

I will un-assign myself from this one.

Allison Browne commented on issue #584177 at GitLab.org / GitLab

2026-02-27T14:12:01Z

The MR to redirect alerts to the sec channel was merged 🎉 gitlab-com/runbooks!10082 (merged)

This also ends up refactoring the alerts to be generated via ./scripts/generate-jsonnet-rules.sh so that they are less duplicative.

Closing the issue.

Allison Browne closed issue #584177: Redirect sec db staturation alerts to the Secure Stage Channel at GitLab.org / GitLab

2026-02-27T14:11:37Z

Allison Browne commented on issue #583 at GitLab.org / Database Team / team-tasks

2026-02-26T22:06:07Z

Another idea would be to create a dashboard to review for the last week for each alert type. That could be less disruptive but lead to a similar result of filing issues for any problematic queries/patterns identified.

I've started to build something like this for CPU saturation. Which would combine the 3 top 10 statements graphs from the runbook as well as links to those queryIds in kibana. Possibly we can add other saturation related metrics like apdex, CPU saturation % and anything else that can cause saturation.

Patroni - CPU Saturation Analysis-1771467144785.json

Allison Browne commented on merge request !10082 at GitLab.com / Runbooks

2026-02-26T21:33:37Z

Thanks @sxuereb, I've addressed your feedback. Let me know what you think 🏓

Allison Browne commented on merge request !10082 at GitLab.com / Runbooks

2026-02-26T21:32:23Z

To be consistent with the original alerts I've removed generating mimir-rules/gitlab-gstg and mimir-rules/gitlab-pre only the production alerts are very relevant here.

Allison Browne pushed to project branch duo-edit-20260206-203849 at GitLab.com / Runbooks

2026-02-26T21:30:11Z

Allison Browne (6fb5ad79) at 26 Feb 21:30

Remove generating gstg and pre files

Allison Browne pushed to project branch duo-edit-20260206-203849 at GitLab.com / Runbooks

2026-02-26T20:40:23Z

Allison Browne (78172381) at 26 Feb 20:40

Allison Browne commented on merge request !10082 at GitLab.com / Runbooks

2026-02-26T20:38:31Z

Since tenant is passed I get:

$ jsonnet -J libsonnet/ -J metrics-catalog/ -J services/ -J vendor/ mimir-rules-jsonnet/patroni-saturation-alerts.jsonnet 
RUNTIME ERROR: function expected 1 positional argument(s), but got 2

when I try to remove this arg, even though it's not used.

Allison Browne pushed to project branch ab-fix-bbm-attribution at GitLab.org / GitLab

2026-02-26T20:02:22Z

Allison Browne (97c9efe0) at 26 Feb 20:02

Fix sidekiq_middleware/server_metrics_spec.rb spec