Re-approving after my approval got reset and reviewing the changes since Julie's excellent review

What does this MR do and why?

This MR updates the search formatting for agent sessions without impacting any other search area functionality.

References

GitLab Work Item: #587223

Screenshots or screen recordings

Before	After

How to set up and validate locally

For DAP/General Setup

• General DAP: https://docs.gitlab.com/development/duo_agent_platform/
• Assigning Duo to a group: https://docs.gitlab.com/development/ai_features/#run-gitlabduosetup-script
• Make sure you are in SaaS mode with export GITLAB_SIMULATE_SAAS=1 set in your env.runit file in your local gdk.
• Turn on the following feature flags: duo_workflow, duo_workflow_in_ci, ai_flow_triggers.

To Test in Agent Sessions page

1. Navigate to a project with that has AI features enabled.
2. In the left side panel, you will see Automate with a tanuki icon. Select Sessions from the dropdown.
3. Test search (see below for test cases)

To Test in new UI Side Panel

1. To test this locally, make sure you have the following FFs enabled: paneled_view, global_topbar, tailwind_container_queriesAfter you can toggle New UI on in user's setting under the user's profile dropdown
2. Open the side panel and open Sessions.
3. Test search (see below for test cases)

Adding Sessions

1. A: If you see no Sessions, you can trigger one that displays a Pipeline/Job by going to an Issue within your Duo enabled project and clicking the Generate MR with Duo button. It should trigger a new session that you can open up.
2. B: You can also run the following query bundle exec rake "gitlab:duo_workflow:populate[50,20,1,<<YOUR_TEST_GROUP_PATH_HERE>>]" to create new agent sessions. Refresh the page. Make sure the group you are testing in has Duo assigned (see DAP setup above).

Test Search (The Actual Testing)

1. Go to the Sessions Index page (see above for Side Panel and Project)
2. Make sure the search matches the proposed design in Figma or in the attached work item.
3. Use the new dropdown selection labeled All or Recent on the left of the Updated query. Select Recent.
4. Validate the filtering works as expected and you can't see any sessions beyond 30 days.
5. Now select All.
6. Validate the filtering displays all items as expected.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #587223

Hi @lindsey-shelton are you available to please give this MR a first pass review?

Allison Villa (690bfbd6) at 17 Mar 21:11

@GitLabDuo this is not required as per the design system docs: https://design.gitlab.com/directives/safe-link/#rel

When setting target to _blank, the rel attribute gets set automatically to noopener noreferrer, this is done to avoid the window.opener API exploit. If you set the rel attribute manually, this will overwrite the aforementioned logic.

Allison Villa (57240372) at 17 Mar 20:58

note for reviewer: The suggestions button and tab are not currently implemented (see docs), however the code for the button is still there and (if enabled) renders where the new AI catalog button is. When enabled, this allows it to sit at the end/bottom of the rail next to the new button.

Allison Villa (695409b8) at 17 Mar 20:24

Allison Villa (26e71c56) at 17 Mar 19:36

Allison Villa (8ef8a24b) at 17 Mar 19:31

Thanks @.luke ! I think I misinterpreted the thread, so your comment cleared it up for me 😅

I think we should keep Type: External for external foundational agents and not Type: Foundational. External foundational agents already have other indicators for them being foundational (tanuki-verified icon, "GitLab-managed" label, Managed by: GitLab after !227332 is merged). WDYT @jglassman1 @amandarueda ?

I also raised the idea of including the "external" label found on external agents in the list view (ie. /explore/ai-catalog/agents/) in the metadata in the details view (#593895)

External agent in the list view:

Missing "external" label and icon in the same external agent's details view:

This could be another way to differentiate them on that page and follows an existing pattern we're using in the list view.

Thanks @jglassman1 ! In the interest of keeping the scope of this MR focused, I made a followup task for the "external" icon+label for external agents - Add "external" label and icon to external agent... (#593895) • Allison Villa • 18.11