I didn't mean to modify them, but Edge seems to be dropping this tilted striped pattern so I'm not even aware of it when testing. Sorry for that. What does it look like originally? Let me know and I'll fix it later.
I assume it is now correct. Please check it :)
asHOH (45a8b183) at 08 Mar 08:13
docs: clarify owned note as "original" than "rarity"
... and 16 more commits
I attempted a fix, but I'm not sure whether it works since I cannot test it locally. Could you send a screenshot if it is still problematic?
Done. Now it is clean.
asHOH (09762994) at 02 Mar 13:51
docs: clarify owned note as "original" than "rarity"
... and 3 more commits
asHOH (5d2a6ce4) at 02 Mar 13:21
docs: clarify owned note as "original" than "rarity"
... and 6 more commits
So it should be a pure darkening effect?
Sadly it's a real compatibility problem - no previous cells are darkened on Edge. Neither on Chrome. (on the production website) I'll try to address it later.
Got it.
I didn't mean to modify them, but Edge seems to be dropping this tilted striped pattern so I'm not even aware of it when testing. Sorry for that. What does it look like originally? Let me know and I'll fix it later.
No idea. To be honest I have no experience on tackling compatibility issues. I'll look into this later this week.
Oops, I only tested it on Edge (Windows).
Perhaps flushing cache or hard-refresh will solve this issue? (I assume Ctrl+F5) Otherwise I have no idea. Looking at the screenshot, there is also a color mismatch problem that I would not expect. I'll probably work on it later (perhaps this weekend).
FYI --owned-bg is currently only set/used inside the inline rules in layout.erb, and is effectively redundant since the overlay comes from tacit.css. Happy to drop it, or leave it as a hook if we ever need to reuse the base gradients elsewhere.
No need to worry about compatibility. It's well supported.
Addressed all review comments. I split the fixes into separate commits.
Tests pass locally (bundle exec rake test: 97 tests, 176 assertions, 0 failures, 0 errors, 0 skips).
Sure! That's much clearer.
asHOH (d90a1fe8) at 28 Feb 08:57
docs: clarify owned note as "original" than "rarity"
... and 4 more commits
Thanks for flagging it. I rarely use the highlight tool so I didn't notice this conflict. Sorry for that.
I think the issue was layering: the owned 10–90% gradients defined later in layout.erb replace the .picked background from tacit.css, so the highlight vanished on owned cells.
I fixed it by changing .picked and .picked_consecutively to draw the dark tint as a ::after pseudo-element on a relatively positioned cell (position: relative; isolation: isolate;). A pseudo-element is rendered above the element’s background layers, so it always sits on top of the rarity/owned gradients.
Now it should work well.
I’m new to Ruby, so pls correct me if I’m off, but I switched to [cursor, rarity, *ownership, *picked].join(' ') as suggested. It looks clearer.
Got it. Working on it.
asHOH (7e8a3b89) at 28 Feb 04:53
feat: additionally display rarity for owned cats
... and 2 more commits