Hey @WarheadsSE could you do a maintainer review on this one?

I could not run it E2E (I wasted a lot of time running gitlab in my local kubernetes cluster but ran in some system errors one after the other). So I instead ran the template with global.gatewayApi.installEnvoy set and unset.

Approving.

What does this MR do?

Gateway API: Expose KAS via gRPC on shared hostname

Serve gRPC traffic for KAS alongside existing HTTP on the same hostname using a single HTTPRoute, as required by the Gateway API cross-serving spec [1]. A BackendTrafficPolicy ensures correct HTTP/2 upstream forwarding for the gRPC traffic.

[1] https://gateway-api.sigs.k8s.io/api-types/grpcroute/#cross-serving

Changelog: added

Related issues

Closes #6217

Relates gitlab-org/cluster-integration/gitlab-agent#766

Test Plan

1. Install GitLab, KAS and Envoy Gateway

   helm upgrade --install gl ~/repos/gitlab-chart/ -n gl --create-namespace \
      -f ~/repos/gitlab-chart/examples/values-gatewayapi.yaml \
      -f my-ip-and-hostname-values.yaml

2. Create a fresh project

3. Create two agents, one connecting via wss one via grpc

4. ✅ Confirm both agents connect

   

Author checklist

For general guidance, please follow our Contributing guide.

Required

For anything in this list which will not be completed, please provide a reason in the MR discussion.

• Merge Request Title and Description are up to date, accurate, and descriptive.
• MR targeting the appropriate branch.
• MR has a green pipeline.
• Documentation created/updated.
• Tests added/updated, and test plan for scenarios not covered by automated tests.
• Equivalent MR/issue for omnibus-gitlab opened.

Reviewers checklist

• MR has a green pipeline on https://gitlab.com/gitlab-org/charts/gitlab.
• Consider downstream impact to the Operator, as per evaluating impact from changes to GitLab chart.

I am not well versed with Python, but content is

content: Union[str, list[ContentBlock]]

(src) and ContentBlock is

ContentBlock = Union[TextContent, ImageContent]

So I do not think we have scope of having a None here.

Ashvin Sharma (a88c8cda) at 19 Mar 10:58

Hey @pshutsin thanks for the change, I left a couple of comments as questions to understand the change a little better. Back to you 🏓.

question: Should we add specs to ensure that event_ids cannot be empty? Or if they are we handle it correctly?

question: Shouldn't this be integer? I see we use user_id as integer in the specs as well.

I am not sure how much enforce this, but is documented to avoid using latin abbreviations-https://docs.gitlab.com/development/documentation/styleguide/word_list/#eg

Ashvin Sharma (08d7993d) at 19 Mar 10:02

Ashvin Sharma (b18a024b) at 19 Mar 10:02

... and 1 more commit

What does this MR do?

Revert "Merge branch 'malvarez-consolidate-http-status-code-field' into 'main'"

This reverts merge request !6492

Why was this MR needed?

The previous changes changed the type of the logging field status from String to Integer. This was pointed out to have the risk of causing type conflicts: Slack (internal) & https://opster.com/guides/elasticsearch/glossary/elasticsearch-conflicting-field/

We are reverting the changes to first figure out the necessary type mappings.

What's the best way to test this MR?

What are the relevant issue numbers?

We already have validation for this. This is a false positive.

We already have validation for this. This is a false positive.

@ajwalker Could you please review this smol MR?

Issue: #39276

What does this MR do?

Bump up runner images version to 0.0.38

and update the docs

Related MRs

gitlab-org/ci-cd/runner-tools/base-images!106

gitlab-org/ci-cd/docker-machine!162

Ashvin Sharma (8602b7d6) at 19 Mar 08:31

Ashvin Sharma (1db22db5) at 19 Mar 08:16

Ashvin Sharma (f518646e) at 19 Mar 08:02