Batuhan Wilhelm (10e39e34) at 14 Dec 22:15

@nick_vh Can someone else wrap it up? Sorry, can't spare too much time anymore since I'm busy, sorry for the inconvenience. I addressed some comments, but not all.

@gitlab-bot ready

RSpec.describe 'PipelineSchedulecreate' do

Consider addding feature_category: <feature_category_name> for this example if it is not set already. See testing best practices.

RSpec.describe Types::Ci::PipelineScheduleVariableType do

Consider addding feature_category: <feature_category_name> for this example if it is not set already. See testing best practices.

This is accepted as ref in the corresponding REST controller, so I wanted to follow it as it's in the controller.

I think FE will send it all the time.

I think we can also make active: true default value, let me know.

I didn't make it nullable, since project path is a required parameter to create pipeline schedule, but I see your point. It's nullable now.

I made this one required.

Batuhan Wilhelm (81eb9ffa) at 26 Nov 10:19

... and 1466 more commits

Batuhan Wilhelm (1a454c87) at 20 Nov 09:52

Batuhan Wilhelm (9aae3bad) at 16 Nov 10:35

... and 3814 more commits

@pburdette I was off last week, will check and adress review comments this week ahead.

Batuhan Wilhelm (f76411f5) at 03 Nov 10:56

Batuhan Wilhelm (7de69f1d) at 03 Nov 10:51

Batuhan Wilhelm (ec4267ed) at 03 Nov 09:42

Yeah sure, I'll fix them. Wanted to get pre-approval before fixing them, in case we may need changes.

Thanks for the kind words, @pburdette. It's taking some time tho, but nevertheless I think we are really close to merging. Waiting for a final round of reviews atm!

@gitlab-bot @allison.browne @alberts-gitlab

Batuhan Wilhelm (2fe85449) at 25 Oct 13:17

... and 669 more commits

@gitlab-bot ready @allison.browne @furkanayhan