Thanks for the info @ahegyi
If the data lag is so short, I wonder if it's even worth displaying this in the UI
Yeah big thanks @rob.hunt for putting this together
In terms of deprecations, we need to ensure that we have telemetry on the endpoints as this will inform the deprecation process.
The breaking change will have negligible customer impact as measured by actual product usage tracking across GitLab Self-Managed, GitLab.com, and GitLab Dedicated. For instance if it impacts less than 1% of the GitLab customer base.
@pshutsin @ahegyi surfacing the last synced at information will be helpful if done right, misleading if not. I guess we have 2 individual considerations here - that I can think of. Data synced from PG to CH (when relevant, data could be external in future cases) and materialized view refreshes. MV refreshes are supposed to happen automatically via an insert trigger (or some other CH magic) but I wonder if we need any additional data points around this i.e. refresh is delayed, failed, etc i.e. data may have synced 10 minutes ago, but the materialized view hasn't yet refreshed which could be misleading
Noooooo
I've tried to address this using DAP, no success - after spending a lot of compute power. Let's give GitLabDuo a shot.
@GitLabDuo are you able to address the above, or do I need to pull the branch and do it manually?
For posterity: I was battling with back and fourth in this thread talking to GitLabDuo. I opened DAP and asked to fix the changes based on the thread and had much better success.
Brandon Labuschagne (09f0a85c) at 18 Mar 14:55
Fix spec file and refactor type file to use exclusion pattern
@GitLabDuo the spec file doesn't look correct, I think in the previously applied patch, the changes intended for the type file were applied to the spec file
We need a clean patch to correct the spec file and apply the cleaner code version to the type file.
@GitLabDuo the diff only applied to the spec file. Can you please also apply the change to the actual type file?
Brandon Labuschagne (06da263e) at 18 Mar 14:48
Apply 1 suggestion(s) to 1 file(s)
@GitLabDuo can you please apply the above to both the type file as well as the spec file?
@GitLabDuo are we able to do the same in !227660 (diffs)?
Brandon Labuschagne (2db798f5) at 18 Mar 14:41
Apply 1 suggestion(s) to 1 file(s)
Brandon Labuschagne (34efe45c) at 18 Mar 14:40
Apply 1 suggestion(s) to 1 file(s)
@adruid can you please review this duo generated MR?