Removes unencrypted "value" column that duplicates encrypted field. Fixes #592747.
| Before | After |
|---|---|
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Brendan O'Connor (71a609b9) at 17 Mar 16:53
Removing unencrypted "value" column that duplicates encrypted field
Brendan O'Connor (9c7e5b39) at 17 Mar 16:48
Removing alias that allows access to unencrypted value column
Just a couple of thoughts off the top of my head:
First, how can we utilize and expand the unit test suite to help ensure the redaction layer functions performantly and doesn't suffer regressions in the future? Do you have documentation on what the test suite covers currently vs what you'd like it to cover?
Secondly, I know you have a lot of existing test cases that are run outside the testing suite (e.g., that you've been using for smoke testing while coding); are those things we can automate and put into the pipeline?
What other areas would you like assistance with?
The profiles system is excellent, and a major addition to OpenBao that Vault doesn't support. I think that the document sets out all the benefits of the work quite well; in particular, enabling direct communication between OpenBao and other parts of GitLab without proxying through the Rails app reduces the attack surface (since Rails could MITM secrets at the moment) and increases the possibility space for what OpenBao/GLSM can do in the app. I'm excited to see where it goes!
Achievements:
Blockers:
Dependencies:
Next Steps:
Next update: 2026-03-20
Achievements:
Blockers:
Dependencies:
Next Steps:
Next update: 2026-03-20
Achievements:
Blockers:
Dependencies:
Next Steps:
Next update: 2026-03-20