Brooke Lew activity https://gitlab.com/brookelew 2026-03-19T01:52:18Z tag:gitlab.com,2026-03-19:5220083760 Brooke Lew commented on merge request !4781 at GitLab.org / charts / GitLab Chart 2026-03-19T01:52:18Z brookelew Brooke Lew

Yep, that's on me, sorry, I squeezed the changes in during my break and hoped that CI would catch any mistakes.

tag:gitlab.com,2026-03-19:5220069686 Brooke Lew pushed to project branch allow-configuring-revision-history-limit at Brooke Lew / GitLab Chart 2026-03-19T01:48:11Z brookelew Brooke Lew

Brooke Lew (4a104334) at 19 Mar 01:48

Syntax fixes

tag:gitlab.com,2026-03-17:5214010265 Brooke Lew commented on merge request !4781 at GitLab.org / charts / GitLab Chart 2026-03-17T17:16:39Z brookelew Brooke Lew

@grigoristh All changes should be in!

tag:gitlab.com,2026-03-17:5214006826 Brooke Lew pushed to project branch allow-configuring-revision-history-limit at Brooke Lew / GitLab Chart 2026-03-17T17:15:50Z brookelew Brooke Lew

Brooke Lew (b0cab4b6) at 17 Mar 17:15

Use hasKey instead of with

tag:gitlab.com,2026-03-17:5214004474 Brooke Lew pushed to project branch allow-configuring-revision-history-limit at Brooke Lew / GitLab Chart 2026-03-17T17:15:15Z brookelew Brooke Lew

Brooke Lew (27bb1c94) at 17 Mar 17:15

Merge branch gitlab:master into allow-configuring-revision-history-...

... and 4 more commits

tag:gitlab.com,2026-03-17:5214003688 Brooke Lew commented on merge request !4781 at GitLab.org / charts / GitLab Chart 2026-03-17T17:15:02Z brookelew Brooke Lew

Oh good catch! I'm slightly annoyed and honestly a little unsettled that slipped by me.

tag:gitlab.com,2026-03-14:5204453154 Brooke Lew commented on merge request !4781 at GitLab.org / charts / GitLab Chart 2026-03-14T20:58:10Z brookelew Brooke Lew

Somewhat relieved to hear that hahah, was not looking forward to editing dozens of files!

tag:gitlab.com,2026-03-13:5203140404 Brooke Lew commented on merge request !4781 at GitLab.org / charts / GitLab Chart 2026-03-13T22:57:08Z brookelew Brooke Lew

Regarding the using with instead of if, I used it because I noticed that the other sections in the file were using the if style method. Would you like me to pop over and update those sections too while I'm here?

tag:gitlab.com,2026-03-13:5203139423 Brooke Lew pushed to project branch allow-configuring-revision-history-limit at Brooke Lew / GitLab Chart 2026-03-13T22:56:23Z brookelew Brooke Lew

Brooke Lew (39c67aff) at 13 Mar 22:56

Fix comment closing delim on line 31 too

tag:gitlab.com,2026-03-13:5203133077 Brooke Lew commented on merge request !4781 at GitLab.org / charts / GitLab Chart 2026-03-13T22:52:55Z brookelew Brooke Lew

Some possibly unaddressed issues

tag:gitlab.com,2026-03-13:5203126263 Brooke Lew commented on merge request !4781 at GitLab.org / charts / GitLab Chart 2026-03-13T22:47:00Z brookelew Brooke Lew

All changes (including non-blocking ones) should be in, thanks!

tag:gitlab.com,2026-03-13:5203124607 Brooke Lew pushed to project branch allow-configuring-revision-history-limit at Brooke Lew / GitLab Chart 2026-03-13T22:45:29Z brookelew Brooke Lew

Brooke Lew (22dfab07) at 13 Mar 22:45

Incorporate suggestions from review

tag:gitlab.com,2026-03-13:5203124016 Brooke Lew pushed to project branch allow-configuring-revision-history-limit at Brooke Lew / GitLab Chart 2026-03-13T22:44:58Z brookelew Brooke Lew

Brooke Lew (7a74179e) at 13 Mar 22:44

Merge branch gitlab:master into allow-configuring-revision-history-...

... and 186 more commits

tag:gitlab.com,2026-02-09:5081991481 Brooke Lew commented on issue #28484 at GitLab.org / gitlab-runner 2026-02-09T04:16:57Z brookelew Brooke Lew

Job logs now seem to be duplicated with the flag on, one line with timestamps and one line without. image

Click to expand
2026-02-09T14:49:47.742584373+11:00 $ echo Release changelog will be:
2026-02-09T14:49:47.742635651+11:00 Release changelog will be:
2026-02-09T14:49:47.742900817+11:00 $ GITLAB_HOST=$CI_SERVER_URL glab changelog generate --version ${CHART_VERSION} || true
$ echo Release changelog will be:
Release changelog will be:
$ GITLAB_HOST=$CI_SERVER_URL glab changelog generate --version ${CHART_VERSION} || true
2026-02-09T14:49:49.211308805+11:00           
2026-02-09T14:49:49.211308805+11:00    ERROR  
2026-02-09T14:49:49.211308805+11:00           
2026-02-09T14:49:49.213302819+11:00   404 Not Found.                                                                                                      
2026-02-09T14:49:49.213302819+11:00 
2026-02-09T14:49:49.217385624+11:00 $ echo "Releasing on ${CI_COMMIT_TAG}"
2026-02-09T14:49:49.217428680+11:00 Releasing on 2.0.0
2026-02-09T14:49:49.217769809+11:00 
2026-02-09T14:49:49.217769809+11:00 {"command_exit_code": 0, "script": "/scripts-13-2509/step_script"}
          
   ERROR  
          
  404 Not Found.
tag:gitlab.com,2026-02-06:5077626199 Brooke Lew commented on task #6253 at GitLab.org / charts / GitLab Chart 2026-02-06T23:12:47Z brookelew Brooke Lew

Any recommendations on how to handle it? Sorry, I've not got much experience with ArgoCD/GitOps, my K8s experience is mostly limited to my tiny Raspberry Pi cluster. I'm thinking of emitting a simple warning if RevisionHistoryLimit is defined for versions <= 1.32. Ideally the warning would only be emitted if the value was changed from the previous revision but that would unnecessarily complicate the chart, and 1.32 is EOL in 3 weeks (28 Feb) anyways. Additionally I think for production environments Gitaly is usually deployed outside of K8s.

tag:gitlab.com,2026-02-05:5073155746 Brooke Lew commented on task #6253 at GitLab.org / charts / GitLab Chart 2026-02-05T20:12:02Z brookelew Brooke Lew

@v1ctorr_ Hi, I've submitted an MR for this, but could you clarify what you said about StatefulSets supporting revisionHistoryLimit starting from v1.33 onwards? I found references to it in the 1.23 docs.

tag:gitlab.com,2026-02-05:5069281525 Brooke Lew opened merge request !4781: Allow configuring revisionHistoryLimit for Deployments and StatefulSets at GitLab.org / charts / GitLab Chart 2026-02-05T00:02:17Z brookelew Brooke Lew

What does this MR do?

Allows configuring revisionHistoryLimits for the chart's Deployments and StatefulSets.

Closes #6253

Author checklist

For general guidance, please follow our Contributing guide.

Required

For anything in this list which will not be completed, please provide a reason in the MR discussion.

  • Merge Request Title and Description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • MR has a green pipeline.
  • Documentation created/updated.
  • Tests added/updated, and test plan for scenarios not covered by automated tests.
  • Equivalent MR/issue for omnibus-gitlab opened.

Reviewers checklist

tag:gitlab.com,2026-02-05:5069279667 Brooke Lew pushed to project branch allow-configuring-revision-history-limit at Brooke Lew / GitLab Chart 2026-02-05T00:01:27Z brookelew Brooke Lew

Brooke Lew (eb715cdb) at 05 Feb 00:01

Allow configuring revisionHistoryLimit for Deployments and Stateful...

tag:gitlab.com,2026-02-04:5069254993 Brooke Lew pushed to project branch allow-configuring-revision-history-limit at Brooke Lew / GitLab Chart 2026-02-04T23:45:25Z brookelew Brooke Lew

Brooke Lew (87e92c57) at 04 Feb 23:45

Allow configuring revisionHistoryLimit for StatefulSets

tag:gitlab.com,2026-02-04:5069230780 Brooke Lew pushed new project branch allow-configuring-revision-history-limit at Brooke Lew / GitLab Chart 2026-02-04T23:32:35Z brookelew Brooke Lew

Brooke Lew (bcb4f054) at 04 Feb 23:32

Allow configuring revisionHistoryLimit