@victorprete Could you please review this Geo MR if you've got time? You can pass it to @dbalexandre for final maintainer review once it looks good to you, as he's got some context on this 🙏

Chloe Fons (1321191e) at 17 Mar 17:44

Chloe Fons (bd55925d) at 17 Mar 17:07

... and 739 more commits

Chloe Fons (dca9448a) at 17 Mar 16:32

... and 1 more commit

@obaiye I could do the project creation on master and switch to your branch once it's failed. Could that work?

Chloe Fons (539d4fa8) at 17 Mar 14:26

@victorprete if you could please re-approve so this can get mwps that'd be brilliant 🙏 thank you!

Chloe Fons (86e16865) at 17 Mar 14:03

what you just explained is actually what I thought was right! I should have trusted myself more and pushed back 🙏

Can you have a final look please @daniele-gitlab?

Chloe Fons (e26765a1) at 17 Mar 13:59

Chloe Fons (513bc607) at 17 Mar 13:25

@obaiye I'm using the URL you've used in your screenshots:

Chloe Fons (75701ca6) at 17 Mar 12:11

... and 867 more commits

Longer term I can imagine it would be a nice-to-have in the UI for all data types

And indeed, it's planned in #570726, but that needs serious refinement and might not be possible due to timeouts on very large tables (job_artifacts, I'm looking at you)

Hi @obaiye thanks! I've been trying the verification steps but I can't create a fake project 🤔 when using a fake git URL I'm faced with "Host cannot be resolved or invalid". How can I create an invalid import?

There's not much to review on the backend besides tests and they LGTM 👍

What does this MR do and why?

This MR implements Step 2 of the deduplication plan tracked in #590458.

The project_repository_states table can contain duplicate rows for the same project_repository_id due to a missing uniqueness constraint. This MR adds a post-deployment migration (DeduplicateProjectRepositoryStates) that cleans up any such existing duplicates and a unique index to ensure no new duplicates will be created.

The deletion can be done in a post-deployment migration because the table is seldom used yet, so will be small. On GitLab.com, it's empty (because Geo is not enabled).

References

• Addresses #590458
• Subtask of #590033

Database considerations

Destructive action

The migration 20260316153056_deduplicate_project_repository_states_spec.rb does remove duplicate records in the project_repository_states table. If something goes wrong and too many/all records are deleted, this will not cause disruption to users:

1. This table is not yet used. It will be used when Project Replication V2 is added and enabled (not before 19.0 at the very earliest). There might already be records in there through the default Geo SSF behaviour, but those records would not be used for actual Geo replication.
2. Geo has mechanisms to periodically populate missing records in this table through the Geo::VerificationStateBackfillService, called every minute from the VerificationCronWorker.

Query plans

TBD

How to set up and validate locally

1. Check out the branch
2. Roll back to before the migrations (if you've already run them)

bundle exec rails db:migrate:down:main VERSION=20260317141445
bundle exec rails db:migrate:down:main VERSION=20260316153056

3. Open the Rails console and create duplicate records:

project = Project.first
repo = project.project_repository
state = repo.project_repository_state # if it doesn't exist, it's OK, we'll create some
state_data = { project_repository_id: repo.id, project_id: project.id }

# Now create and duplicate this existing state
Geo::ProjectRepositoryState.insert_all([state_data, state_data]) # insert 2 additional records

# Verify there's more than one record for the repo:
Geo::ProjectRepositoryState.where(project_repository_id: repo.id)

4. Now run the migrations:

bundle exec rails db:migrate VERSION=20260316153056
bundle exec rails db:migrate VERSION=20260317141445

5. Verify in the console:

# No duplicates remain
Geo::ProjectRepositoryState.where(project_repository_id: repo.id) # only returns 1 record

6. Inserting a duplicate record does not work anymore:

# This'll return @rows=[] meaning no row was inserted
Geo::ProjectRepositoryState.insert(project_repository_id: repo.id, project_id: repo.project_id, verification_state: 0)

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Chloe Fons (bcfa42ae) at 17 Mar 11:06

Chloe Fons (d5c116d8) at 17 Mar 10:37

... and 1 more commit

Thank you for the review @daniele-gitlab! I've addressed your comment. Could you please have a last look and setting MWPS if it looks good? 🙏

Right, good point. I'm always quite confused with exactly when it's best to use let vs. let_it_be. Thanks for the guidance @daniele-gitlab